converted slashcommand-join coffee to js #6469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
requested changes
Mar 28, 2017
| @@ -0,0 +1,10 @@ | |||
| RocketChat.slashCommands.add('join', void 0, { | |||
| */ | ||
|
|
||
|
|
||
| const Join = function(command, params, item) { |
There was a problem hiding this comment.
IMHO named functions are better for theses cases, cuz the stack trace of the errors will be more clear.
What do you think about change const Join = function(command... by function Join(command...?
| }, user.language) | ||
| }); | ||
| } | ||
| if (room.usernames.indexOf(user.username) > -1) { |
There was a problem hiding this comment.
Can you replace the indexOf by includes?
rodrigok
approved these changes
Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core