converted rocketchat-message-mark-as-unread coffee/js #6445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
requested changes
Mar 23, 2017
| icon: 'icon-flag', | ||
| i18nLabel: 'Mark_as_unread', | ||
| context: ['message', 'message-mobile'], | ||
| action: function() { |
There was a problem hiding this comment.
Change action: function() { to action() {
| i18nLabel: 'Mark_as_unread', | ||
| context: ['message', 'message-mobile'], | ||
| action: function() { | ||
| var message = this._arguments[1]; |
There was a problem hiding this comment.
Lets never user var, you can use const here
| @@ -0,0 +1,30 @@ | |||
| Meteor.startup(function() { | |||
There was a problem hiding this comment.
Places where you don't want to access the scope (this) you can use () => { instead of function() {
| if (error) { | ||
| return handleError(error); | ||
| } | ||
| subscription = ChatSubscription.findOne({ |
There was a problem hiding this comment.
Remove the above declaration and use const here
| return FlowRouter.go('home'); | ||
| }); | ||
| }, | ||
| validation: function(message) { |
There was a problem hiding this comment.
Same thing here, use validation() {
| @@ -0,0 +1,29 @@ | |||
| import logger from './logger'; | |||
| Meteor.methods({ | |||
| unreadMessages: function(firstUnreadMessage) { | |||
There was a problem hiding this comment.
Use the short way here unreadMessages() {
| import logger from './logger'; | ||
| Meteor.methods({ | ||
| unreadMessages: function(firstUnreadMessage) { | ||
| var lastSeen, originalMessage; |
There was a problem hiding this comment.
Do not declare variables before use when there is no need.
| logger.connection.debug('Provided message is already marked as unread'); | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
Where are the last 2 lines of code?
rodrigok
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core