Password reset Cleaner text #6319
Conversation
There was a problem hiding this comment.
this cannot close #6229 because the register/login button label bug was not fixed
also, this is now warning the user if the e-mail address was not found on database which is feature I think we would like to keep.
| @@ -5,6 +5,9 @@ Meteor.methods({ | |||
| email = email.trim(); | |||
|
|
|||
| const user = RocketChat.models.Users.findOneByEmailAddress(email); | |||
| if (!user) { | |||
There was a problem hiding this comment.
I think you can use an else in the if below, it will check for user once one time.
There was a problem hiding this comment.
That shouldn’t be there, my bad.
|
As an alternative to this, some websites send an email to the address you enter either giving you instructions to reset your password if the account exists, or sends you an email saying that you haven't registered with the email. E.g. |
|
I liked the @alexbrazier idea |
|
@karlprieb @sampaiodiego Could you do a review of this pr again? I have already did the changes |
MartinSchoeler
changed the title
|
@sampaiodiego What do you think? |
@RocketChat/core
Related to #6229 (comment)