Join command #6268
Merged
Join command #6268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlprieb
reviewed
Mar 8, 2017
|
|
||
| room = RocketChat.models.Rooms.findOneByNameAndType(channel, 'c') | ||
|
|
||
| RocketChat.Notifications.notifyUser Meteor.userId(), 'message', { |
There was a problem hiding this comment.
you can omit braces in coffeescript :)
There was a problem hiding this comment.
I know, but it doesn't mean I like it :) . I'm goin to fix this now.
@engelgabriel said something about change this solution to something more generic.
There was a problem hiding this comment.
Hehehe I told you about the that because we omit braces on RC codebase :)
karlprieb
approved these changes
Mar 8, 2017
rodrigok
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #5793
It will works just with public channels.