Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement /gif command (using rightgif) #6090

Closed
wants to merge 2 commits into from
Closed

implement /gif command (using rightgif) #6090

wants to merge 2 commits into from

Conversation

billtt
Copy link
Contributor

@billtt billtt commented Feb 18, 2017

@RocketChat/core

Closes #6088

Implement slash command /gif for chat. Query rightgif service and show a gif image according to the keyword following the command.

command preview
image

command effect

/gif rocket

image

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2017

CLA assistant check
All committers have signed the CLA.

@graywolf336
Copy link
Contributor

My opinion, these type of things need to be integrations. What we really need to implement is the ability for outgoing integrations to have the option of whether they should show up as commands, that would enable "custom" commands. Then we need another component which allows them to provide previews which the user can select from before it sends a message, for example how discord does it:

image

@joshsleeper
Copy link

joshsleeper commented Mar 31, 2017

@graywolf336
This is absolutely the right answer.
I've used both Slack and HipChat commands like /gif that just auto-select some random gif and most of my team finds it nearly useless.

Discord does a great job, and Telegram also has a great gif selection paradigm (via the @gif inline bot) if you wanted another good example of how to do it right!

@graywolf336 graywolf336 mentioned this pull request Jun 15, 2017
@graywolf336
Copy link
Contributor

Thanks again for this pull request, however I am going to be closing this due to the coming soon #6890 which already has support for slash commands to act like native commands. Also, my earlier comment still applies and we will be getting the pop up/suggestions feature as well in the future. :)

@graywolf336 graywolf336 added the App: Idea An Idea for a Rocket.Chat App label Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: Idea An Idea for a Rocket.Chat App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New feature: integrate rightgif service as a slash command (/gif)
4 participants