Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Groups rename fix #5599

Merged
merged 1 commit into from
Jan 16, 2017
Merged

API Groups rename fix #5599

merged 1 commit into from
Jan 16, 2017

Conversation

MartinSchoeler
Copy link
Contributor

The Rest API Groups rename method was returning a channel object, when it was supposed to return a group object.

@RocketChat/core

@MartinSchoeler
groups rename fix
990c419 
groups rename was returning a channel object, when it was supposed to return a group object
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-5599 January 16, 2017 16:52 Inactive
graywolf336
graywolf336 approved these changes Jan 16, 2017
View reviewed changes
Copy link
Contributor

@graywolf336 graywolf336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is why we need them tests you're working on. 👍

@engelgabriel engelgabriel merged commit 0595acb into develop Jan 16, 2017
@engelgabriel engelgabriel deleted the MartinSchoeler-patch-1 branch January 16, 2017 17:06
@engelgabriel engelgabriel added this to the 0.49.2 milestone Jan 16, 2017
This was referenced Oct 9, 2024
Open
Open
@toshanmugaraj toshanmugaraj mentioned this pull request Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graywolf336 graywolf336 graywolf336 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.49.2
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinSchoeler @graywolf336 @engelgabriel