Removal of Template, Blaze, BlazeLayout, FlowRouter, DDPRateLimiter, Session, UAParser, Promise, Reload and CryptoJS global variables

.eslintrc

@@ -7,17 +7,12 @@
 		"AgentUsers"                  : false,
 		"Apps"                        : false,
 		"Assets"                      : false,
-		"Blaze"                       : false,
-		"BlazeLayout"                 : false,
 		"browser"                     : false,
 		"ChatMessage"                 : false,
 		"ChatMessages"                : false,
 		"ChatRoom"                    : false,
 		"ChatSubscription"            : false,
-		"CryptoJS"                    : false,
 		"Department"                  : false,
-		"DDPRateLimiter"              : false,
-		"FlowRouter"                  : false,
 		"FileUpload"                  : false,
 		"getNextAgent"                : false,
 		"handleError"                 : false,
@@ -34,25 +29,20 @@
 		"Npm"                         : false,
 		"Package"                     : false,
 		"parentCall"                  : false,
-		"Promise"                     : false,
-		"Reload"                      : false,
 		"RocketChat"                  : true,
 		"RocketChatFile"              : false,
 		"RoomHistoryManager"          : false,
 		"RoomManager"                 : false,
 		"ServiceConfiguration"        : false,
-		"Session"                     : false,
 		"Settings"                    : false,
 		"SideNav"                     : false,
 		"t"                           : false,
 		"TAPi18n"                     : false,
 		"TAPi18next"                  : false,
-		"Template"                    : false,
 		"TimeSync"                    : false,
 		"toastr"                      : false,
 		"Trigger"                     : false,
 		"Triggers"                    : false,
-		"UAParser"                    : false,
 		"visitor"                     : false,
 		"VideoRecorder"               : false,
 		"VRecDialog"                  : false

client/helpers/escapeCssUrl.js

@@ -1 +1,3 @@
+import { Template } from 'meteor/templating';
+
 Template.registerHelper('escapeCssUrl', (url) => url.replace(/(['"])/g, '\\$1'));

client/helpers/log.js

@@ -1,3 +1,5 @@
+import { Template } from 'meteor/templating';
+
 Template.registerHelper('log', (...args) => {
 	console.log.apply(console, args);
 });

client/helpers/not.js

@@ -1 +1,3 @@
+import { Template } from 'meteor/templating';
+
 Template.registerHelper('not', (value) => !value);

client/notifications/notification.js

@@ -1,6 +1,8 @@
 /* globals KonchatNotification, fireGlobalEvent, readMessage, CachedChatSubscription */
 import { Meteor } from 'meteor/meteor';
 import { Tracker } from 'meteor/tracker';
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { Session } from 'meteor/session';
 
 // Show notifications and play a sound for new messages.
 // We trust the server to only send notifications for interesting messages, e.g. direct messages or

client/routes/adminRouter.js

@@ -1,3 +1,6 @@
+import { FlowRouter } from 'meteor/kadira:flow-router' ;
+import { BlazeLayout } from 'meteor/kadira:blaze-layout';
+
 FlowRouter.route('/admin/users', {
 	name: 'admin-users',
 	action() {

client/routes/roomRoute.js

@@ -1,3 +1,5 @@
+import { FlowRouter } from 'meteor/kadira:flow-router';
+
 FlowRouter.goToRoomById = (roomId) => {
 	const subscription = ChatSubscription.findOne({ rid: roomId });
 	if (subscription) {

client/routes/router.js

@@ -2,6 +2,10 @@
 import { Meteor } from 'meteor/meteor';
 import { Accounts } from 'meteor/accounts-base';
 import { Tracker } from 'meteor/tracker';
+import { Blaze } from 'meteor/blaze';
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { BlazeLayout } from 'meteor/kadira:blaze-layout';
+import { Session } from 'meteor/session';
 import s from 'underscore.string';
 
 Blaze.registerHelper('pathFor', function(path, kw) {

client/startup/emailVerification.js

@@ -1,5 +1,6 @@
 import { Meteor } from 'meteor/meteor';
 import { Tracker } from 'meteor/tracker';
+import { Session } from 'meteor/session';
 import toastr from 'toastr';
 
 Meteor.startup(function() {

client/startup/loginViaQuery.js

@@ -1,4 +1,6 @@
 import { Meteor } from 'meteor/meteor';
+import { FlowRouter } from 'meteor/kadira:flow-router';
+
 Meteor.startup(() => {
 	if (FlowRouter.getQueryParam('resumeToken')) {
 		Meteor.loginWithToken(FlowRouter.getQueryParam('resumeToken'), () => {

client/startup/roomObserve.js

@@ -1,4 +1,6 @@
 import { Meteor } from 'meteor/meteor';
+import { Session } from 'meteor/session';
+
 Meteor.startup(function() {
 	ChatRoom.find().observe({
 		added(data) {

client/startup/startup.js

@@ -1,6 +1,7 @@
 /* globals UserPresence, fireGlobalEvent */
 import { Meteor } from 'meteor/meteor';
 import { Tracker } from 'meteor/tracker';
+import { Session } from 'meteor/session';
 import toastr from 'toastr';
 import hljs from 'highlight.js';
 import 'highlight.js/styles/github.css';

client/startup/unread.js

@@ -1,6 +1,8 @@
 /* globals fireGlobalEvent, readMessage, Favico, favico, menu */
 import { Meteor } from 'meteor/meteor';
 import { Tracker } from 'meteor/tracker';
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { Session } from 'meteor/session';
 
 Meteor.startup(function() {
 	Tracker.autorun(function() {

client/startup/usersObserve.js

@@ -1,4 +1,6 @@
 import { Meteor } from 'meteor/meteor';
+import { Session } from 'meteor/session';
+
 Meteor.startup(function() {
 	Meteor.users.find({}, { fields: { name: 1, username: 1, pictures: 1, status: 1, emails: 1, phone: 1, services: 1, utcOffset: 1 } }).observe({
 		added(user) {

imports/message-read-receipt/client/main.js

@@ -1,3 +1,5 @@
+import { Template } from 'meteor/templating';
+
 Template.main.helpers({
 	readReceiptsEnabled() {
 		if (RocketChat.settings.get('Message_Read_Receipt_Store_Users')) {

imports/message-read-receipt/client/readReceipts.js

@@ -1,5 +1,6 @@
 import { Meteor } from 'meteor/meteor';
 import { ReactiveVar } from 'meteor/reactive-var';
+import { Template } from 'meteor/templating';
 import moment from 'moment';
 
 import './readReceipts.css';

imports/personal-access-tokens/client/personalAccessTokens.js

@@ -2,6 +2,7 @@ import { Meteor } from 'meteor/meteor';
 import { Mongo } from 'meteor/mongo';
 import { ReactiveVar } from 'meteor/reactive-var';
 import { Tracker } from 'meteor/tracker';
+import { Template } from 'meteor/templating';
 import toastr from 'toastr';
 import moment from 'moment';
 

packages/chatpal-search/client/route.js

@@ -1,3 +1,6 @@
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { BlazeLayout } from 'meteor/kadira:blaze-layout';
+
 FlowRouter.route('/admin/chatpal', {
 	name: 'chatpal-admin',
 	action() {

packages/chatpal-search/client/template/admin.js

@@ -1,5 +1,6 @@
 import { Meteor } from 'meteor/meteor';
 import { ReactiveVar } from 'meteor/reactive-var';
+import { Template } from 'meteor/templating';
 import toastr from 'toastr';
 
 Template.ChatpalAdmin.onCreated(function() {

packages/chatpal-search/client/template/result.js

@@ -1,5 +1,7 @@
 import { DateFormat } from 'meteor/rocketchat:lib';
 import { ReactiveVar } from 'meteor/reactive-var';
+import { Session } from 'meteor/session';
+import { Template } from 'meteor/templating';
 
 Template.ChatpalSearchResultTemplate.onCreated(function() {
 	this.badRequest = new ReactiveVar(false);

packages/chatpal-search/client/template/suggestion.js

@@ -1,3 +1,5 @@
+import { Template } from 'meteor/templating';
+
 Template.ChatpalSuggestionItemTemplate.onCreated(function() {
 	if (this.data.type === 'link') {
 		this.data.action = () => {

packages/chatpal-search/package.js

@@ -13,6 +13,7 @@ Package.onUse(function(api) {
 		'rocketchat:logger',
 		'rocketchat:search',
 		'kadira:flow-router',
+		'kadira:blaze-layout',
 		'meteorhacks:inject-initial',
 	]);
 

packages/meteor-autocomplete/client/autocomplete-client.js

@@ -1,6 +1,7 @@
 /* globals Deps, getCaretCoordinates*/
 import { Meteor } from 'meteor/meteor';
 import { Match } from 'meteor/check';
+import { Blaze } from 'meteor/blaze';
 import _ from 'underscore';
 import AutoCompleteRecords from './collection';
 

packages/meteor-autocomplete/client/templates.js

@@ -1,4 +1,6 @@
 /* globals AutoComplete */
+import { Blaze } from 'meteor/blaze';
+import { Template } from 'meteor/templating';
 import _ from 'underscore';
 
 //  Events on template instances, sent to the autocomplete class

packages/rocketchat-2fa/client/accountSecurity.js

@@ -1,5 +1,6 @@
 import { Meteor } from 'meteor/meteor';
 import { ReactiveVar } from 'meteor/reactive-var';
+import { Template } from 'meteor/templating';
 import toastr from 'toastr';
 import qrcode from 'yaqrcode';
 

packages/rocketchat-action-links/client/init.js

@@ -1,4 +1,7 @@
 /* globals fireGlobalEvent */
+import { Blaze } from 'meteor/blaze';
+import { Template } from 'meteor/templating';
+
 Template.room.events({
 	'click .action-link'(event, instance) {
 		event.preventDefault();

packages/rocketchat-analytics/client/loadScript.js

@@ -1,5 +1,6 @@
 import { Meteor } from 'meteor/meteor';
 import { Tracker } from 'meteor/tracker';
+import { Template } from 'meteor/templating';
 
 Template.body.onRendered(() => {
 	Tracker.autorun((c) => {

packages/rocketchat-analytics/client/trackEvents.js

@@ -1,4 +1,5 @@
 import { Meteor } from 'meteor/meteor';
+import { FlowRouter } from 'meteor/kadira:flow-router';
 import { Tracker } from 'meteor/tracker';
 
 function trackEvent(category, action, label) {

packages/rocketchat-apps/client/admin/appInstall.js

@@ -8,6 +8,8 @@
 // then it will be enabled by default for development reasons. The server prefers a url
 // over the passed in body, so if both are found it will only use the url.
 import { ReactiveVar } from 'meteor/reactive-var';
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { Template } from 'meteor/templating';
 
 Template.appInstall.helpers({
 	appFile() {

packages/rocketchat-apps/client/admin/appLogs.js

@@ -1,4 +1,6 @@
 import { ReactiveVar } from 'meteor/reactive-var';
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { Template } from 'meteor/templating';
 import moment from 'moment';
 import hljs from 'highlight.js';
 

packages/rocketchat-apps/client/admin/appManage.js

@@ -1,5 +1,7 @@
 import { Meteor } from 'meteor/meteor';
 import { ReactiveVar } from 'meteor/reactive-var';
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { Template } from 'meteor/templating';
 import _ from 'underscore';
 import s from 'underscore.string';
 import toastr from 'toastr';

packages/rocketchat-apps/client/admin/appWhatIsIt.js

@@ -1,5 +1,7 @@
 import { Meteor } from 'meteor/meteor';
 import { ReactiveVar } from 'meteor/reactive-var';
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { Template } from 'meteor/templating';
 
 Template.appWhatIsIt.onCreated(function() {
 	this.isLoading = new ReactiveVar(false);

packages/rocketchat-apps/client/admin/apps.js

@@ -1,5 +1,7 @@
 import toastr from 'toastr';
 import { ReactiveVar } from 'meteor/reactive-var';
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { Template } from 'meteor/templating';
 
 import { AppEvents } from '../communication';
 const ENABLED_STATUS = ['auto_enabled', 'manually_enabled'];

packages/rocketchat-apps/client/orchestrator.js

@@ -1,6 +1,8 @@
 import { Meteor } from 'meteor/meteor';
 import { AppWebsocketReceiver } from './communication';
 import { Utilities } from '../lib/misc/Utilities';
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { BlazeLayout } from 'meteor/kadira:blaze-layout';
 
 class AppClientOrchestrator {
 	constructor() {

packages/rocketchat-apps/package.js

@@ -11,7 +11,7 @@ Package.onUse(function(api) {
 		'templating',
 	]);
 
-	api.use(['reactive-var', 'kadira:flow-router', 'underscore'], 'client');
+	api.use(['reactive-var', 'kadira:flow-router', 'kadira:blaze-layout', 'underscore'], 'client');
 
 	api.addFiles('lib/Apps.js', ['client', 'server']);
 

packages/rocketchat-authorization/client/hasPermission.js

@@ -1,5 +1,6 @@
 /* globals ChatPermissions */
 import { Meteor } from 'meteor/meteor';
+import { Template } from 'meteor/templating';
 
 function atLeastOne(permissions = [], scope) {
 	return permissions.some((permissionId) => {

packages/rocketchat-authorization/client/route.js

@@ -1,3 +1,6 @@
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { BlazeLayout } from 'meteor/kadira:blaze-layout';
+
 FlowRouter.route('/admin/permissions', {
 	name: 'admin-permissions',
 	action(/* params*/) {

packages/rocketchat-authorization/client/views/permissions.js

@@ -2,6 +2,7 @@
 import { Meteor } from 'meteor/meteor';
 import { ReactiveVar } from 'meteor/reactive-var';
 import { Tracker } from 'meteor/tracker';
+import { Template } from 'meteor/templating';
 
 Template.permissions.helpers({
 	role() {

packages/rocketchat-authorization/client/views/permissionsRole.js

@@ -1,5 +1,7 @@
 import { Meteor } from 'meteor/meteor';
 import { ReactiveVar } from 'meteor/reactive-var';
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { Template } from 'meteor/templating';
 import toastr from 'toastr';
 
 Template.permissionsRole.helpers({

packages/rocketchat-authorization/package.js

@@ -14,6 +14,7 @@ Package.onUse(function(api) {
 
 	api.use('mongo', ['client', 'server']);
 	api.use('kadira:flow-router', 'client');
+	api.use('kadira:blaze-layout', 'client');
 	api.use('tracker', 'client');
 
 	api.use('templating', 'client');

packages/rocketchat-autotranslate/client/views/autoTranslateFlexTab.js

@@ -2,6 +2,7 @@
 import { Meteor } from 'meteor/meteor';
 import { ReactiveVar } from 'meteor/reactive-var';
 import { Random } from 'meteor/random';
+import { Template } from 'meteor/templating';
 import _ from 'underscore';
 import toastr from 'toastr';
 

packages/rocketchat-autotranslate/server/methods/getSupportedLanguages.js

@@ -1,4 +1,5 @@
 import { Meteor } from 'meteor/meteor';
+import { DDPRateLimiter } from 'meteor/ddp-rate-limiter';
 
 Meteor.methods({
 	'autoTranslate.getSupportedLanguages'(targetLanguage) {

packages/rocketchat-channel-settings-mail-messages/client/resetSelection.js

@@ -1,3 +1,5 @@
+import { Blaze } from 'meteor/blaze';
+
 export default function resetSelection(reset) {
 	const [el] = $('.messages-box');
 	if (!el) {

packages/rocketchat-channel-settings-mail-messages/client/views/mailMessagesInstructions.js

@@ -1,6 +1,9 @@
 /* global AutoComplete Deps */
 import { Meteor } from 'meteor/meteor';
 import { ReactiveVar } from 'meteor/reactive-var';
+import { Blaze } from 'meteor/blaze';
+import { Session } from 'meteor/session';
+import { Template } from 'meteor/templating';
 import toastr from 'toastr';
 import resetSelection from '../resetSelection';
 

packages/rocketchat-channel-settings/client/startup/trackSettingsChange.js

@@ -1,5 +1,7 @@
 import { Meteor } from 'meteor/meteor';
 import { Tracker } from 'meteor/tracker';
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { Session } from 'meteor/session';
 
 Meteor.startup(function() {
 	const roomSettingsChangedCallback = (msg) => {

packages/rocketchat-channel-settings/client/views/channelSettings.js

@@ -1,6 +1,7 @@
 /* globals popover */
 import { Meteor } from 'meteor/meteor';
 import { ReactiveVar } from 'meteor/reactive-var';
+import { Template } from 'meteor/templating';
 import toastr from 'toastr';
 import moment from 'moment';
 import s from 'underscore.string';

packages/rocketchat-custom-sounds/client/admin/adminSounds.js

@@ -1,7 +1,9 @@
-import s from 'underscore.string';
 import { ReactiveVar } from 'meteor/reactive-var';
 import { RocketChatTabBar } from 'meteor/rocketchat:lib';
 import { Tracker } from 'meteor/tracker';
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { Template } from 'meteor/templating';
+import s from 'underscore.string';
 
 Template.adminSounds.helpers({
 	isReady() {

packages/rocketchat-custom-sounds/client/admin/route.js

@@ -1,4 +1,6 @@
 import { Meteor } from 'meteor/meteor';
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { BlazeLayout } from 'meteor/kadira:blaze-layout';
 
 FlowRouter.route('/admin/custom-sounds', {
 	name: 'custom-sounds',