Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] sidenav size on large screens #12372

Merged
merged 2 commits into from
Oct 20, 2018
Merged

[NEW] sidenav size on large screens #12372

merged 2 commits into from
Oct 20, 2018

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Oct 19, 2018

before

image

after

image

@ggazzo ggazzo added the ui/ux label Oct 19, 2018
@ggazzo ggazzo requested a review from tassoevan October 19, 2018 14:39
@ggazzo ggazzo added this to the 0.71.0 milestone Oct 19, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12372 October 19, 2018 14:39 Inactive
…debar-header.css

Co-Authored-By: ggazzo <guilhermegazzo@gmail.com>
@ggazzo ggazzo merged commit 5e18176 into develop Oct 20, 2018
@ggazzo ggazzo deleted the sidenav-percent branch October 20, 2018 02:59
@sampaiodiego sampaiodiego mentioned this pull request Oct 27, 2018
@himpierre
Copy link

himpierre commented Oct 31, 2018

Has this fix made it to 0.71.0? I still have the big gap between user icon and search icon.

cheers
t.

@himpierre
Copy link

Uh, maybe i understood the merge wrong. This gap is supposed to be there now, right?

@ghost
Copy link

ghost commented Nov 16, 2018

Why? Not to be rude, but this looks like shit on any view mode other than Extended... please make it an option or used in Extended only.....??? it adds a weird gap between the icons and user, it makes all the channels too wide (lots of empty space, except on Extended), and still doesn't release the Administration button from its overflow button (why not? overflows with 1 item in them that'd easily fit in the container look dumb)

just my 2 cents

@ghost
Copy link

ghost commented Nov 16, 2018

or maybe a draggable separator.....

@Eiken
Copy link

Eiken commented Nov 16, 2018

Just wanted to say i agree with tsukiRep. On big high res monitors the sidebar gets insanely wide. Is there some setting to revert told behavior or could a setting be added?

EDIT: Added some custom CSS to set max width to work around it for now.

@divergefx
Copy link

Just wanted to say i agree with tsukiRep. On big high res monitors the sidebar gets insanely wide. Is there some setting to revert told behavior or could a setting be added?

EDIT: Added some custom CSS to set max width to work around it for now.

I dislike the expanded sidebar as well, added the following to custom css to override:

.sidebar{
flex: 0 0 0;
}

@tobru
Copy link

tobru commented Nov 22, 2018

It looks weird on big screens, I prefer the old look...

@ghost
Copy link

ghost commented Nov 29, 2018

there is already a css variable controlling the side bar width:

--sidebar-width

this PR uses hard-coded flex, width and max-width.. it is inconsistent and it makes overriding the behaviour with custom-css very tricky.

@ggazzo
Copy link
Member Author

ggazzo commented Nov 29, 2018

hey guys thanks for yours comments,and I have to say that I agree with most of them... if you are not using the extendend mode the sidenav looks a litte... empty...

we have another problem to allow users choose their own size (by drag) because if you open the rocketchat by a desktop app, you can have a lot of different sizes (one per server)...

I promise we gonna find a better way. We are "testing" because we have large monitors and we dont need (we thought at least) a huge area to chat...

@cx-gokhan-berberoglu I'm aware about the css variables... because I created that variables (:. but we coulnt find a reason to allow overwrite that values, but sure when we fix/solve/change we can introduce new variables (or just remove de old code)...

@tassoevan
Copy link
Contributor

I don't think a draggable separator can be easily implemented -- @ggazzo made a good point about the desktop app, while layout reflow is heavy and hurtful for users with a significant amount of subscriptions at the sidebar too --, but we could act quick for a temporary resolution. I believe the motivation for this pull request was to rationally use more screen area because some users switch more between rooms and because a large chat area is bad for reading. I need to discuss how to handle wider displays without hurting readability.

@tassoevan tassoevan removed the design label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants