[IMPROVE] Livechat room closure endpoints #12360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested changes
Oct 19, 2018
| } | ||
|
|
||
| const user = Meteor.user(); | ||
|
|
||
| if (!RocketChat.Livechat.closeRoom({ user, room, comment })) { |
There was a problem hiding this comment.
you cannot call closeRoom here before test bellow
sampaiodiego
approved these changes
Oct 20, 2018
sampaiodiego
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few server methods calling the
RocketChat.Livechat.closeRoommethod, but the room validations were scattered among the server methods and not in theRocketChat.Livechat.closeRoommethod.This PR fixes this by centralizing the validations in the Livechat method.