Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve: Drop database between running tests on CI #12358

Merged
merged 2 commits into from
Oct 19, 2018
Merged

Improve: Drop database between running tests on CI #12358

merged 2 commits into from
Oct 19, 2018

Conversation

sampaiodiego
Copy link
Member

This will hopefully help tests to pass 👼

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12358 October 18, 2018 15:12 Inactive
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-12358 October 18, 2018 18:10 Inactive
geekgonecrazy
geekgonecrazy approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@geekgonecrazy geekgonecrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively could use a different db for each test. But I think this way works too :)

@sampaiodiego sampaiodiego merged commit 18a64d3 into develop Oct 19, 2018
@sampaiodiego sampaiodiego deleted the dropdatabase-between-tests branch October 19, 2018 11:40
@sampaiodiego sampaiodiego mentioned this pull request Oct 27, 2018
Merged
reist pushed a commit to seekingalpha/Rocket.Chat that referenced this pull request Apr 15, 2019
@sampaiodiego @reist
Improve: Drop database between running tests on CI (RocketChat#12358)
17a400e 
* Drop database between running tests on CI

* Add mongo shell dependency
reist pushed a commit to seekingalpha/Rocket.Chat that referenced this pull request Apr 15, 2019
@sampaiodiego @reist
Improve: Drop database between running tests on CI (RocketChat#12358)
2597135 
* Drop database between running tests on CI

* Add mongo shell dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekgonecrazy geekgonecrazy geekgonecrazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sampaiodiego @geekgonecrazy @engelgabriel