[FIX] Double output of message actions #11902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actions markup is output twice, in immediate succession: https://github.com/RocketChat/Rocket.Chat/blob/135c6f8e1bb204cd7b07682dec8e189144fe3871/packages/rocketchat-message-attachments/client/messageAttachment.html#L152-L158 @ubarsaiyan and @ggazzo - Please review and get this merged asap. Did no one even look at this feature before it went in release?
|
@timkinnane I noticed it when it was deployed and sent a PR asap but got no response. #11853 |
|
Right. Thanks @ubarsaiyan I searched issues for "actions" but not buttons. Better to be specific, there's a lot of buttons in Rocket.Chat. |
|
@timkinnane Sorry, I thought this would be merged quickly so didn't give much thought in the title. I will keep this is in mind from now onwards. :) |
|
@ubarsaiyan was your PR merged? Can I close this? |
Kishn0109
pushed a commit
to Kishn0109/Rocket.Chat
that referenced
this pull request
May 26, 2023
Actions markup is output twice, in immediate succession: https://github.com/RocketChat/Rocket.Chat/blob/135c6f8e1bb204cd7b07682dec8e189144fe3871/packages/rocketchat-message-attachments/client/messageAttachment.html#L152-L158 @ubarsaiyan and @ggazzo - Please review and get this merged asap. Did no one even look at this feature before it went in release?
janainaCoelhoRocketchat
pushed a commit
that referenced
this pull request
Aug 18, 2023
Actions markup is output twice, in immediate succession: https://github.com/RocketChat/Rocket.Chat/blob/135c6f8e1bb204cd7b07682dec8e189144fe3871/packages/rocketchat-message-attachments/client/messageAttachment.html#L152-L158 @ubarsaiyan and @ggazzo - Please review and get this merged asap. Did no one even look at this feature before it went in release?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actions markup is output twice, in immediate succession:
Rocket.Chat/packages/rocketchat-message-attachments/client/messageAttachment.html
Lines 152 to 162 in 135c6f8
@ubarsaiyan and @ggazzo - Please review and get this merged asap. Did no one even look at this feature before it got merged?