Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] SVG icons code #11319

Merged
merged 3 commits into from
Jul 6, 2018
Merged

[FIX] SVG icons code #11319

merged 3 commits into from
Jul 6, 2018

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jul 3, 2018 •
edited
Loading

This pull request aims to format the SVG file containing the UI icons.

  • Fix indentation
  • Sort icons alphabetically by id
  • Recover icons lost in c1a5d57

@tassoevan tassoevan added bounty App: Idea An Idea for a Rocket.Chat App labels Jul 3, 2018
@tassoevan tassoevan requested a review from ggazzo July 3, 2018 03:24
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11319 July 3, 2018 03:24 Inactive
@tassoevan tassoevan added ui/ux type: improvement and removed App: Idea An Idea for a Rocket.Chat App bounty labels Jul 3, 2018
@tassoevan tassoevan added this to the 0.67.0 milestone Jul 3, 2018
karlprieb
karlprieb previously approved these changes Jul 3, 2018
View reviewed changes
@tassoevan tassoevan changed the title [FIX] SVG icons code [WIP] [FIX] SVG icons code Jul 4, 2018
@tassoevan tassoevan changed the title [WIP] [FIX] SVG icons code [FIX] SVG icons code Jul 4, 2018
@ggazzo ggazzo merged commit 830607d into develop Jul 6, 2018
@ggazzo ggazzo deleted the fix.icons branch July 6, 2018 03:01
@theorenck theorenck modified the milestones: 0.67.0, 0.68.0 Jul 19, 2018
@sampaiodiego sampaiodiego mentioned this pull request Jul 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@karlprieb karlprieb karlprieb left review comments

Assignees
No one assigned
Labels
type: improvement ui/ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tassoevan @ggazzo @karlprieb @engelgabriel @theorenck