-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Slackbridge: send attachment notifications #10269
[NEW] Slackbridge: send attachment notifications #10269
Conversation
Introduced ES2015 Import/Export to resolve dependencies
…at into dynamic-groups
…at into slackbridge-attachments
@Hudell can you fix the conflict? |
…at into slackbridge-attachments
@@ -68,6 +68,18 @@ class SlackBridge { | |||
logger.class.debug(`Setting: ${ key }`, value); | |||
}); | |||
|
|||
//Import messages from Slack with an alias; %s is replaced by the username of the user. If empty, no alias will be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this makes part of this PR?
|
||
//Hack to notify that a file was attempted to be uploaded | ||
delete slackMessage.subtype; | ||
slackMessage.text = `Uploaded a file: ${ slackMessage.file.permalink }`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we post this as an attachment to have the preview and remove that, not translated, text?
file_name = Meteor.absoluteUrl(title_link); | ||
} | ||
|
||
const message = `Uploaded a file: ${ file_name }`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea of how to not have that text? Have a fixed text in english seems wrong.
@RocketChat/core
Closes an item on #8012 , merging PR #6309
Original Description: