Fix: possible errors on rocket.chat side of the apps #10252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,7 +50,7 @@ export class AppUsersConverter { | |||
| case 'bot': | |||
| return UserType.BOT; | |||
| default: | |||
| throw new Error('Unknown user type of:', type); | |||
| return type.toUpperCase(); | |||
There was a problem hiding this comment.
Should we keep spitting out at least a warning?
To at least make sure we are always aware that we have types that aren't valid?
We should be striving for default to never be hit. If we have to do so by being annoying to our self maybe not such a bad thing?
There was a problem hiding this comment.
Added some warning logs now. 👍
rodrigok
approved these changes
Mar 28, 2018
rodrigok
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These errors were added to ensure the data to the Rocket.Chat Apps system could be guaranteed, however this sadly can not be the case as Rocket.Chat doesn't have internal data verification and ensurations.