-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New issue template for *Release Process* #10234
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4e68b57
Create issue template for release process
rodrigok e0c5129
Updated some minor wording
geekgonecrazy 99635d3
Add `Before Release` steps
rodrigok 1f6e445
Merge branch 'develop' into release-process
geekgonecrazy 3b99021
fix highlight typo
geekgonecrazy 06bad37
Merge branch 'develop' into release-process
geekgonecrazy 964339e
Update release.md
rodrigok d1efc4a
Update release.md
rodrigok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| # Release {version} | ||
| We are releasing a new version, this issue will keep track of the progress between the first release candidate (20th of each month) to the final release (27th of each month). | ||
|
|
||
| After the 20th of each month we start the release process that ends 7 days after, during that period we enter a Feature Freeze. While in the Feature Freeze, we will only be merging bug fixes and not new features. | ||
|
|
||
| For any regression, open a new issue and link to this one. | ||
|
|
||
|
|
||
| ## Before Release - Preparation - 1 business day before the day 20th | ||
| - [x] Create the issue to track the release progress | ||
| - [ ] Define the highlights from release PRs as suggestion to be included on Blog Post | ||
| - [ ] Talk to the Marketing Team about the Blog Post release | ||
| - [ ] Talk to the Documentation Team about the Docs release | ||
| - [ ] Sync translations from [LingoHub](https://translate.lingohub.com/rocketchat/rocket-dot-chat/dashboard) | ||
|
|
||
| ## Release Candidate 1 - On the 20th | ||
| - [ ] Delete branch `release-candidate` | ||
| - [ ] Create branch `release-candidate` based on `develop` | ||
| - [ ] On branch `release-candidate` run `npm run release` and follow the steps | ||
| - [ ] Publish the branch and the generated tag | ||
| - [ ] Edit the tag on GitHub and paste the generated History removing the version from the first line and mark the checkbox **This is a pre-release** | ||
| - [ ] Ensure the build is passing on CircleCI | ||
| - [ ] Ensure the build is passing on Docker Hub | ||
|
|
||
| <!-- Copy following block for next release candidates | ||
| ## Release Candidate {release-candidate-version} | ||
| - [ ] Merge `develop` into `release-candidate` branch | ||
| - [ ] On branch `release-candidate` run `npm run release` and follow the steps | ||
| - [ ] Publish the branch and the generated tag | ||
| - [ ] Edit the tag on GitHub and paste the generated History removing the version from the first line and mark the checkbox **This is a pre-release** | ||
| - [ ] Ensure the build is passing on CircleCI | ||
| - [ ] Ensure the build is passing on Docker Hub | ||
| --> | ||
|
|
||
| ## Final Release - On the 27th | ||
| - [ ] Merge `develop` into `release-candidate` branch | ||
| - [ ] Create a new branch `release-{version}` based on `release-candidate` | ||
| - [ ] On branch `release-{version}` run `npm run release` and follow the steps **TODO: fix the history** | ||
| - [ ] Publish only the branch | ||
| - [ ] **Draft a new release** on GitHub | ||
| - [ ] Enter tag version as {version} | ||
| - [ ] Select target **master** | ||
| - [ ] Enter release title as {version} | ||
| - [ ] Paste the history removing the version from the first line | ||
| - [ ] Save as **draft** | ||
| - [ ] Create a PR from the branch `release-{version}` with the same history from the tag/release | ||
| - [ ] Ensure the build is passing on CircleCI | ||
| - [ ] Ensure the build is passing on Docker Hub | ||
| - [ ] When build is passing ask for approval | ||
| - [ ] When approved merge it! | ||
| - [ ] When merged edit the release/tag and publish it | ||
|
|
||
| ## After Release - Conclusion - 1 business day after the 27th | ||
| - [ ] Check if related issues was closed | ||
| - [ ] Check if related issues was assigned to the correct milestone | ||
| - [ ] Check with the Marketing Team about the Blog Post release | ||
| - [ ] Check with the Documentation Team about the Docs release | ||
| - [ ] Create a Sync PR to merge back master to develop | ||
| - [ ] Merge Sync PR | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sampaiodiego Explain please.. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sry, it was too late to explain 😛
so, I might not have understood correctly at the time I read. but reading it again I guess we will not merge anything to
developduring freeze time? if so, this sentence is correctThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be incorrect. We will be merging bug fixes into develop. Ideally between the time of the first release candidate and the release there will be more release candidates which contain the bug fixes merged, thus when the final release happens there won't be much to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, true, you're right.. but we'll be merging only bug fixes introduced by the release candidate in progress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we or are we not? I honestly feel that we do not need to limit ourselves to saying we will only merge bugs introduced by the release candidate. Otherwise we will be limiting ourselves and even be questioning whether the bug was introduced in the release candidate or whether it existed before.