Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice messaging does not work anymore #10530

Closed
HammyHavoc opened this issue Apr 20, 2018 · 53 comments
Closed

Voice messaging does not work anymore #10530

HammyHavoc opened this issue Apr 20, 2018 · 53 comments

Comments

@HammyHavoc
Copy link
Contributor

Description:

Server Setup Information:

  • Version of Rocket.Chat Server: 0.63.3
  • Operating System: 4.13.0-37-generic
  • Deployment Method(snap/docker/tar/etc): Snap
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • Node Version: v8.11.1
  • mongoDB Version:

Steps to Reproduce:

  1. Record a voice message
  2. Play it back
  3. Sit baffled in silence for hours on end 😣

Expected behavior:

Actual behavior:

To hear the voice message.

Voice message doesn't record any audio. Spent a couple hours troubleshooting this, even went as far as buying a Blue Yeti microphone; turns out it doesn't send audio even on other devices, even on a Surface Pro's built-in mic. All microphones work just fine in other programs.

Relevant logs:

@HammyHavoc HammyHavoc changed the title Voice messaing does not work anymore Voice messaging does not work anymore Apr 20, 2018
@theorenck
Copy link
Contributor

Hi @HammyHavoc can you give us a little more context on the problem? From what browser (and version) are you trying to send a voice message?

@HammyHavoc
Copy link
Contributor Author

We use the Windows desktop app primarily, but it also doesn't work in Firefox on Windows. x64 on Windows 10's latest build.

@alireza-salehi
Copy link

Same issue on windows 10 1709 (build 16.299.371)
---Windows App Version 2.10.5,
---Web version on Chrome 66.0.3359.139 & Firefox 59.0.3

Deployment:
Server Version 0.64.0
CentOs 7 - Release | 3.10.0-693.21.1.el7.x86_64
Node Version | v8.9.3
Running on valid SSL cert with Nginx reverse proxy.

i can send an audio message, but nothing recorded, when i play the file there is nothing. it is empty.

@mwarth
Copy link

mwarth commented May 28, 2018

Any update here? We are currently evaluating Rocket.Chat for company use and facing the same issue with the desktop app 2.10.5 on Windows 10 1803 as well as Firefox ESR 60.0.1.

Deployment:
Server Version: 0.64.2
Ubuntu Server 18.04 with latest updates - snap deployment
Running on valid wildcard ssl certificate with caddy proxy.

@Sveer
Copy link

Sveer commented May 31, 2018

Have the same issue. On some laptops audio record is working well, but on others we have silence in recorded file.
File only with header.
https://github.com/mattdiamond/Recorderjs lib working.

@eszeus
Copy link

eszeus commented Jun 11, 2018

Same issue here, no audio, its just silent.

@alireza-salehi
Copy link

alireza-salehi commented Jun 11, 2018

same issue on 0.65.1 and electron windows client 2.11.0 on windows 10 1803 (17134.1)

@szab100
Copy link

szab100 commented Jun 18, 2018

This fails on many platform (tried iOS/saphari+chrome, Desktop/Mac, Linux Chrome, Firefox).. This is a major issue.. As others mentioned, the underlying recorderjs library worked, particularly, this test works perfectly: https://webaudiodemos.appspot.com/AudioRecorder/index.html

Any chance this can get fixed anytime soon ?! It's very odd that here's this feature and simply not working in about 2/3 of cases..

@engelgabriel engelgabriel added this to the 0.67.0 milestone Jul 11, 2018
@gigitux
Copy link
Contributor

gigitux commented Jul 16, 2018

I have same error on Android and iOS devices (both Chrome and Firefox).

No problem on Chrome/Firefox on PC desktop

@theorenck theorenck modified the milestones: 0.67.0, 0.68.0 Jul 19, 2018
@theorenck theorenck modified the milestones: 0.68.0, Short-term Jul 31, 2018
@malevka
Copy link

malevka commented Aug 16, 2018

I have the same error on Windows 7 with desktop app 2.12.1 and web version on Chrome 68.0.3440.106

@yZhenyuanLiu
Copy link

Same issue here, no audio, its just silent.

@edmondtor
Copy link

same issue....
Any chance to get a fix soon ?

@HitomiTenshi
Copy link

Same issue here with the latest Windows x64 Desktop Client. Recorded audio is just silent. My microphone works fine in Jitsi Video Conferences.

@GeorgeBarkley
Copy link

Same issue, Windows 10 Education 1803 Build 17134.376 RocketChat app 2.14.1

@octanefilms
Copy link

same issue Error message: File exceeds allowed size of 0 B. [error-file-too-large]
server log message:

�[34mI20181119-12:55:15.329(-5) �[34mMeteor ➔ method ufsCreate -> userId: PtXKDyfLq3Ym7qEoH , arguments: [ { name: 'Audio record.mp3', size: 20271, type: 'audio/mp3', rid: 'PtXKDyfLq3Ym7qEoHWcnCEAw7zMMj6ywav', description: '', store: 'Uploads' } ]

  • Rocket Chat server Version | 0.71.1
  • Mac OS Mojave 10.14.1 (18B75) with RC desktop client Version 2.13.3 and 2.14.3
  • Chrome Mac OS Version 70.0.3538.102 (Official Build) (64-bit)

Audio does not seem to record any data. Mac OS permissions for Rocket Chat and Chrome are in place and valid.

Computer hardware internal mic is working with other applications.

@octanefilms
Copy link

ok... So had to set the server to accept data in the <rocketchat.base.url>/admin/FileUpload section to a non-zero byte value and use the GRID FS storage type as I don't have any of the other file storage parameters set up such as S3 or local file storage.

Works in desktop client now.
Works in Chrome now.

  • Safari

web client has no microphone option at all.

@szab100
Copy link

szab100 commented Nov 19, 2018

@octanefilms if you have a fix, maybe you could create a PR?

@octanefilms
Copy link

Hey @szab100, it was a change of admin settings rather than a code fix. Had to allocate storage in the RC FileUpload settings so that the audio that was being correctly captured by the RC client would be accepted for storage via the included GRID FS storage parameter. Other options for storage in that Admin section too such as using an Amazon S3 bucket.

However, the Mac OS Safari web browser still not showing any microphone icon at all. So no UI method to invoke audio clips from a Safari web RC session. See image.

Hope that helps.

image

@HitomiTenshi
Copy link

@octanefilms Whatever settings you did, it still doesn't work on my side. Here are mine:

chrome_2018-11-20_19-44-34

@riddlenl
Copy link

riddlenl commented Dec 1, 2018

Same here, empty files

@matthewbassett
Copy link

Same here. Works without issue from the mac desktop client with my setup, won't work from windows 10 desktop client. Any movement on this? Everything from the logs looks normal no errors, file successfully uploads and stores in GRIDFS. However when you play it from any client, all you hear is silence. Any ideas on this? The fact that I can upload voice messages from other clients tells me that the issue isn't a server side config issue.

@ggazzo ggazzo added the ui/ux label Dec 13, 2018
@rkramer1964
Copy link

rkramer1964 commented Feb 12, 2019

Got audio working here (across the board). The problem lies in the lamejs.min.js (lamejs) component. Specifically, the fill_buffer_resample in Lame.js (original source tree) computes a fractional index (j2) into the sample buffer (like -29.5) and inbuf[j2] gives "undefined" which results in NaN values in the mp3 buffer that is sent to Rocket.Chat. And that gives silence.

I've forked the original code and fixed it. My version is here: https://github.com/rkramer1964/lamejs

A PR has been submitted to zhuker/lamejs so now we wait for uptake....

Replacing the .../rocketchat/programs/web.browser/app/lame.min.js with mine >>should<< do the trick.

All this because my boss wanted to send voicemail via RC....

@matthewbassett
Copy link

Hi @tassoevan our org is wondering if this fix could make it into a minor version update so the fix can be pushed out right away. Our users are anxious for this functionality (: Thanks again for everyone's hard work on RC, its a fantastic app and we are really excited about the good things its doing for communication in our org. 👍

@DenisAraujo68
Copy link

DenisAraujo68 commented Feb 13, 2019

I resolved my problem by following what @rkramer1964 said.
Thank you, @rkramer1964

@rkramer1964
Copy link

rkramer1964 commented Feb 13, 2019

@DenisAraujo68 I was experiencing the file is totally silent issue that was at the beginning of this thread. My mic never hung loading indefinitely. Have you tried loading in chrome, hitting F12 then ctrl-R to refresh, recording an audio and seeing what error messages there are in the console? That might shed some light on the problem.

I'm seeing some promise-related errors, but they don't appear to be affecting the recording.

(I hate the "it works on my machine syndrome" so I really want to see what I need to fix. We have it working on a variety - 7+ machines working with the desktop client + webpage on OS/X mojave, win 8, win 10, win 7, and ubuntu linux so I'm sorry it doesn't work for you)

@DenisAraujo68
Copy link

DenisAraujo68 commented Feb 14, 2019

Hi, @rkramer1964. Thank you for your support.

@rkramer1964
Copy link

yes, I think we should.

@rkramer1964
Copy link

To everyone - if you download just lame.min.js from github by right-click, save link as - you will get HTML, not javascript. Best to download the zip file and extract the lame.min.js for replacement that way.

Cheers!

@tassoevan
Copy link
Contributor

@rkramer1964 I did a bunch of changes in #13486. Could you check if it's fine? I wasn't unable to reproduce the bug before.

@rkramer1964
Copy link

Downloaded your fix/audio-message branch, built and tested it. Reviewed changes and all seems to work fine. No new console errors noted.

Cheers!

@Sonit90
Copy link

Sonit90 commented Mar 12, 2019

Are you going to update ubuntu snap with this fix? Audio recording doesn't work for latest Ubuntu snap build.

@tassoevan
Copy link
Contributor

@Sonit90 It was not reviewed after some corrections, but will launch in version 1.0.0. Usually the snap build is deployed two weeks after an official Rocket.Chat release.

@dreamup
Copy link

dreamup commented Mar 18, 2019

I installed rocket.chat via Snap last week and the voice messages are not working from android. Is it related to the update?

@franckadil
Copy link

For people using docker-compose you can solve this issue with the following:

  1. Create a folder that we will use as a volume to persist the fix:
    Mine is named /fixes.

  2. Download the lame.min.js file from https://github.com/rkramer1964/lamejs

3.Put it iside the folder you have just created (in this example: fixes)

  1. Add a volume as shown bellow:

rocketchat:
image: rocketchat/rocket.chat:latest
container_name: rocketchat
restart: unless-stopped
volumes:
- ./uploads:/uploads
- ./fixes/lame.min.js:/app/bundle/programs/web.browser/app/lame.min.js
#The line above fixes mp3 recording until we get new release.
##10530

@premanandmanimaran
Copy link

premanandmanimaran commented May 1, 2019

Voice Messaging is not working
Even after replacing lame.min.js into ..opt/rocketchat/programs/web.browser/app/lame.min.js
I tried it in chrome browser , windows desktop, mac os desktop and safari and its not working.
When i tried it Mobile device through browser ( not RC app) its working.
I am i missing any steps.
Do i need to restart rocketchat?

@DenisAraujo68
Copy link

Hi, @premanandmanimaran .
I don't know if it's the same problem is happening to you, but for me, I downloaded an HTML file instead of lame.min.js file. You can open the lame.min.js file and see if your file has the same content.
You don't need to restart the server. What you could do is reload the rocketchat client.

@alireza-salehi
Copy link

alireza-salehi commented May 2, 2019

RocketChat 0.74.3 / Voice Messaging (Recording Audio Message):
works fine on:

  1. Chorme 74.0.x on win 10

not working and recorded audio message is empty on:

  1. Chorme 73.0.x on android phone
  2. Firefox 66.0.3 / Windows 10 x64 1809(17763.439)
  3. RocketChat.Electron 2.15.3 / Windows 10 x64 1809(17763.439)

steps i did:

  1. replacing lame.min.js (/opt/Rocket.Chat/programs/web.browser/app/lame.min.js)
  2. clearing clients cache
    will fix the issue for:
  • Chorme 73.0.x on android phone
  • Firefox 66.0.3 / Windows 10 x64 1809(17763.439)

but still no success on RocketChat.Electron 2.15.3 , no audio messaging for desktop client.

@horvan
Copy link

horvan commented May 2, 2019

can confirm this bug is fixed in 1.01

@premanandmanimaran
Copy link

@DenisAraujo68

I downloaded the Zip from Lame.min.js and replaced it in /opt/Rocket.Chat/programs/web.browser/app/lame.min.js

in Mac OS - Electron App ( I build this today)
After reload its working fine

in Mac OS - Safari Browser Version 12.0
Its working fine

in Mac OS - Chrome Browser Version 73.0.3683.103
its working fine

in Windows - Electron App
After reload / Clearing cache also its not working.

in Windows - Chrome Browser Version 73.0.3683.103
After clearing cache its working

I am gonna try building the windows electron app once again.

@premanandmanimaran
Copy link

In the New Windows Desktop build it works.

@MrPoint1400
Copy link

MrPoint1400 commented Apr 10, 2022

Unable to send voice message.

Version of Rocket.Chat Server: 4.6.1 docker
mongoDB Version: 5.0
google chrome permission is full and version is 100.

record.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests