-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voice messaging does not work anymore #10530
Comments
Hi @HammyHavoc can you give us a little more context on the problem? From what browser (and version) are you trying to send a voice message? |
We use the Windows desktop app primarily, but it also doesn't work in Firefox on Windows. x64 on Windows 10's latest build. |
Same issue on windows 10 1709 (build 16.299.371) Deployment: i can send an audio message, but nothing recorded, when i play the file there is nothing. it is empty. |
Any update here? We are currently evaluating Rocket.Chat for company use and facing the same issue with the desktop app 2.10.5 on Windows 10 1803 as well as Firefox ESR 60.0.1. Deployment: |
Have the same issue. On some laptops audio record is working well, but on others we have silence in recorded file. |
Same issue here, no audio, its just silent. |
same issue on 0.65.1 and electron windows client 2.11.0 on windows 10 1803 (17134.1) |
This fails on many platform (tried iOS/saphari+chrome, Desktop/Mac, Linux Chrome, Firefox).. This is a major issue.. As others mentioned, the underlying recorderjs library worked, particularly, this test works perfectly: https://webaudiodemos.appspot.com/AudioRecorder/index.html Any chance this can get fixed anytime soon ?! It's very odd that here's this feature and simply not working in about 2/3 of cases.. |
I have same error on Android and iOS devices (both Chrome and Firefox). No problem on Chrome/Firefox on PC desktop |
I have the same error on Windows 7 with desktop app 2.12.1 and web version on Chrome 68.0.3440.106 |
Same issue here, no audio, its just silent. |
same issue.... |
Same issue here with the latest Windows x64 Desktop Client. Recorded audio is just silent. My microphone works fine in Jitsi Video Conferences. |
Same issue, Windows 10 Education 1803 Build 17134.376 RocketChat app 2.14.1 |
same issue Error message: File exceeds allowed size of 0 B. [error-file-too-large]
Audio does not seem to record any data. Mac OS permissions for Rocket Chat and Chrome are in place and valid. Computer hardware internal mic is working with other applications. |
ok... So had to set the server to accept data in the <rocketchat.base.url>/admin/FileUpload section to a non-zero byte value and use the GRID FS storage type as I don't have any of the other file storage parameters set up such as S3 or local file storage. Works in desktop client now.
web client has no microphone option at all. |
@octanefilms if you have a fix, maybe you could create a PR? |
Hey @szab100, it was a change of admin settings rather than a code fix. Had to allocate storage in the RC FileUpload settings so that the audio that was being correctly captured by the RC client would be accepted for storage via the included GRID FS storage parameter. Other options for storage in that Admin section too such as using an Amazon S3 bucket. However, the Mac OS Safari web browser still not showing any microphone icon at all. So no UI method to invoke audio clips from a Safari web RC session. See image. Hope that helps. |
@octanefilms Whatever settings you did, it still doesn't work on my side. Here are mine: |
Same here, empty files |
Same here. Works without issue from the mac desktop client with my setup, won't work from windows 10 desktop client. Any movement on this? Everything from the logs looks normal no errors, file successfully uploads and stores in GRIDFS. However when you play it from any client, all you hear is silence. Any ideas on this? The fact that I can upload voice messages from other clients tells me that the issue isn't a server side config issue. |
Got audio working here (across the board). The problem lies in the lamejs.min.js (lamejs) component. Specifically, the fill_buffer_resample in Lame.js (original source tree) computes a fractional index (j2) into the sample buffer (like -29.5) and inbuf[j2] gives "undefined" which results in NaN values in the mp3 buffer that is sent to Rocket.Chat. And that gives silence. I've forked the original code and fixed it. My version is here: https://github.com/rkramer1964/lamejs A PR has been submitted to zhuker/lamejs so now we wait for uptake.... Replacing the .../rocketchat/programs/web.browser/app/lame.min.js with mine >>should<< do the trick. All this because my boss wanted to send voicemail via RC.... |
Hi @tassoevan our org is wondering if this fix could make it into a minor version update so the fix can be pushed out right away. Our users are anxious for this functionality (: Thanks again for everyone's hard work on RC, its a fantastic app and we are really excited about the good things its doing for communication in our org. 👍 |
I resolved my problem by following what @rkramer1964 said. |
@DenisAraujo68 I was experiencing the file is totally silent issue that was at the beginning of this thread. My mic never hung loading indefinitely. Have you tried loading in chrome, hitting F12 then ctrl-R to refresh, recording an audio and seeing what error messages there are in the console? That might shed some light on the problem. I'm seeing some promise-related errors, but they don't appear to be affecting the recording. (I hate the "it works on my machine syndrome" so I really want to see what I need to fix. We have it working on a variety - 7+ machines working with the desktop client + webpage on OS/X mojave, win 8, win 10, win 7, and ubuntu linux so I'm sorry it doesn't work for you) |
Hi, @rkramer1964. Thank you for your support. |
yes, I think we should. |
To everyone - if you download just lame.min.js from github by right-click, save link as - you will get HTML, not javascript. Best to download the zip file and extract the lame.min.js for replacement that way. Cheers! |
@rkramer1964 I did a bunch of changes in #13486. Could you check if it's fine? I wasn't unable to reproduce the bug before. |
Downloaded your fix/audio-message branch, built and tested it. Reviewed changes and all seems to work fine. No new console errors noted. Cheers! |
Are you going to update ubuntu snap with this fix? Audio recording doesn't work for latest Ubuntu snap build. |
@Sonit90 It was not reviewed after some corrections, but will launch in version 1.0.0. Usually the snap build is deployed two weeks after an official Rocket.Chat release. |
I installed rocket.chat via Snap last week and the voice messages are not working from android. Is it related to the update? |
For people using docker-compose you can solve this issue with the following:
3.Put it iside the folder you have just created (in this example: fixes)
rocketchat: |
Voice Messaging is not working |
Hi, @premanandmanimaran . |
RocketChat 0.74.3 / Voice Messaging (Recording Audio Message):
not working and recorded audio message is empty on:
steps i did:
but still no success on RocketChat.Electron 2.15.3 , no audio messaging for desktop client. |
can confirm this bug is fixed in 1.01 |
I downloaded the Zip from Lame.min.js and replaced it in /opt/Rocket.Chat/programs/web.browser/app/lame.min.js in Mac OS - Electron App ( I build this today) in Mac OS - Safari Browser Version 12.0 in Mac OS - Chrome Browser Version 73.0.3683.103 in Windows - Electron App in Windows - Chrome Browser Version 73.0.3683.103 I am gonna try building the windows electron app once again. |
In the New Windows Desktop build it works. |
Unable to send voice message. Version of Rocket.Chat Server: 4.6.1 docker record.mp4 |
Description:
Server Setup Information:
Steps to Reproduce:
Expected behavior:
Actual behavior:
To hear the voice message.
Voice message doesn't record any audio. Spent a couple hours troubleshooting this, even went as far as buying a Blue Yeti microphone; turns out it doesn't send audio even on other devices, even on a Surface Pro's built-in mic. All microphones work just fine in other programs.
Relevant logs:
The text was updated successfully, but these errors were encountered: