Fix visitor ending livechat if multiples still open (#6419)

Close #6416
RocketChat · Mar 23, 2017 · a32eb12 · a32eb12
1 parent 914e260
commit a32eb12
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/packages/rocketchat-livechat/app/client/views/options.js b/packages/rocketchat-livechat/app/client/views/options.js
@@ -11,7 +11,7 @@ Template.options.events({
 			closeOnConfirm: false,
 			html: false
 		}, () => {
-			Meteor.call('livechat:closeByVisitor', (error) => {
+			Meteor.call('livechat:closeByVisitor', visitor.getRoom(), (error) => {
 				if (error) {
 					return console.log('Error ->', error);
 				}

diff --git a/packages/rocketchat-livechat/server/methods/closeByVisitor.js b/packages/rocketchat-livechat/server/methods/closeByVisitor.js
@@ -1,10 +1,10 @@
 Meteor.methods({
-	'livechat:closeByVisitor'() {
+	'livechat:closeByVisitor'(roomId) {
 		if (!Meteor.userId()) {
 			throw new Meteor.Error('error-not-authorized', 'Not authorized', { method: 'livechat:closeByVisitor' });
 		}
 
-		const room = RocketChat.models.Rooms.findOneOpenByVisitorId(Meteor.userId());
+		const room = RocketChat.models.Rooms.findOneOpenByVisitorId(Meteor.userId(), roomId);
 
 		if (!room || !room.open) {
 			return false;

diff --git a/packages/rocketchat-livechat/server/models/Rooms.js b/packages/rocketchat-livechat/server/models/Rooms.js
@@ -115,8 +115,9 @@ RocketChat.models.Rooms.findByVisitorId = function(visitorId) {
 	return this.find(query);
 };
 
-RocketChat.models.Rooms.findOneOpenByVisitorId = function(visitorId) {
+RocketChat.models.Rooms.findOneOpenByVisitorId = function(visitorId, roomId) {
 	const query = {
+		_id: roomId,
 		open: true,
 		'v._id': visitorId
 	};