This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Change refs in one pass, making switching refs atomic #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor change that ideally shouldn't be user-visible.
Before #92, there was a bug in Roact where when refs were updated, nothing would happen. There was a typo in the reconciler code that resulted in the comparison in the reconciler always determining that refs never changed!
After #92, an issue was unveiled by @ZoteTheMighty via some internal Roact code that means that with the typical use of a ref:
...there is a period of time where
self.foo
will benil
when Roact nullifies the old ref, makes changes, and then passes the same object to the new ref, since by function identity it changed. This doesn't affect code that keeps a stable ref function, and is only visible to code that acts on a ref in response to a change event.Checklist before submitting:
CHANGELOG.md
Tests added and updatedI don't think we can test this