This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Rename reify to mount and teardown to unmount #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPGhatguy
changed the title
LPGhatguy
force-pushed
the
rename-mount-unmount
branch
from
a692e88
to
6c6d032
Compare
LPGhatguy
force-pushed
the
rename-mount-unmount
branch
from
6c6d032
to
637a3cf
Compare
ZoteTheMighty
approved these changes
May 9, 2018
|
I force-pushed my change to hide my mistake as well :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82.
This starts to bring Roact's terminology more into focus, and should get rid of a couple of confusing terms: reification and teardown (which doesn't have a good present-tense verb form).
Now, everywhere can refer to mounting and unmounting as the process.
TODO:
ReconcilerCompat