This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Allow functions to be passed to setState #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPGhatguy
suggested changes
Mar 5, 2018
lib/Component.lua
Outdated
| @@ -121,6 +121,11 @@ function Component:setState(partialState) | |||
| error(INVALID_SETSTATE_MESSAGE, 0) | |||
| end | |||
|
|
|||
| -- If the partial state is a function, invoke it to get the actual partial state. | |||
| if type(partialState) == "function" then | |||
| partialState = partialState(self.props, self.state) | |||
There was a problem hiding this comment.
Let's flip-flop the arguments to match React. I think most cases of functional setState are going to depend on state more than props anyhow.
There was a problem hiding this comment.
Makes sense; fixed now!
lib/Component.spec.lua
Outdated
|
|
||
| expect(getStateCallback().value).to.equal(0) | ||
|
|
||
| setStateCallback(function(props, state) |
There was a problem hiding this comment.
We might want to assert which argument is which in this function to guard against them being the wrong tables!
LPGhatguy
approved these changes
Mar 5, 2018
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #33. It allows
setStateto accept a function, which is called with thepropsandstatetables. This function is expected to return a partial state, which is then used to update the component's state.