Remove values from setState #38

AmaranthineCodices · 2018-03-04T16:31:25Z

This fixes #30. It adds a Roact.None symbol that, when used in setState, will remove the key from the state.

Usage:

-- state already contains a value named "value"
self:setState({
    value = Roact.None,
})

-- state no longer contains "value"

coveralls · 2018-03-04T16:34:35Z

Coverage increased (+0.1%) to 84.917% when pulling 13dc159 on AmaranthineCodices:remove-from-setState into e554ad9 on Roblox:master.

LPGhatguy · 2018-03-05T00:55:45Z

lib/Core.lua

@@ -19,6 +19,9 @@ Core.Ref = Symbol.named("Ref")
 -- Marker used to specify that a component is a Roact Portal.
 Core.Portal = Symbol.named("Portal")

+-- Market used to specify that the value is nothing, because nil cannot be stored in tables.


Typo! s/Market/Marker

Oops! Fixed now.

LPGhatguy · 2018-03-05T01:23:34Z

Looks good to me!

AmaranthineCodices added 3 commits March 4, 2018 11:29

add Core.None symbol for representing nothing

0358cb6

remove values from state when they are Core.None

c7284d3

test removal behavior

7fd8d40

LPGhatguy reviewed Mar 5, 2018

View reviewed changes

Market -> Marker (oops)

13dc159

LPGhatguy merged commit bb60936 into Roblox:master Mar 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove values from setState #38

Remove values from setState #38

AmaranthineCodices commented Mar 4, 2018

coveralls commented Mar 4, 2018 •

edited

Loading

LPGhatguy Mar 5, 2018

AmaranthineCodices Mar 5, 2018

LPGhatguy commented Mar 5, 2018

Remove values from setState #38

Remove values from setState #38

Conversation

AmaranthineCodices commented Mar 4, 2018

coveralls commented Mar 4, 2018 • edited Loading

LPGhatguy Mar 5, 2018

Choose a reason for hiding this comment

AmaranthineCodices Mar 5, 2018

Choose a reason for hiding this comment

LPGhatguy commented Mar 5, 2018

coveralls commented Mar 4, 2018 •

edited

Loading