Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Fix updateChildren re-rentrancy issue #301

Merged
merged 17 commits into from
May 25, 2021
Merged

Fix updateChildren re-rentrancy issue #301

merged 17 commits into from
May 25, 2021

Commits on May 4, 2021

  1. New test

    @ConorGriffin37
    ConorGriffin37 committed May 4, 2021
    Configuration menu
    Copy the full SHA
    3224ec0 View commit details
    Browse the repository at this point in the history

  2. Try fix test

    @ConorGriffin37
    ConorGriffin37 committed May 4, 2021
    Configuration menu
    Copy the full SHA
    1c80565 View commit details
    Browse the repository at this point in the history

  3. Now fix test maybe

    @ConorGriffin37
    ConorGriffin37 committed May 4, 2021
    Configuration menu
    Copy the full SHA
    1ce1ea6 View commit details
    Browse the repository at this point in the history

  4. Try fix test again

    @ConorGriffin37
    ConorGriffin37 committed May 4, 2021
    Configuration menu
    Copy the full SHA
    ae9ac85 View commit details
    Browse the repository at this point in the history

  5. ChildAdded might work instead

    @ConorGriffin37
    ConorGriffin37 committed May 4, 2021
    Configuration menu
    Copy the full SHA
    edf631f View commit details
    Browse the repository at this point in the history

  6. remove test

    @ConorGriffin37
    ConorGriffin37 committed May 4, 2021
    Configuration menu
    Copy the full SHA
    1b1fe5f View commit details
    Browse the repository at this point in the history

  7. remove event

    @ConorGriffin37
    ConorGriffin37 committed May 4, 2021
    Configuration menu
    Copy the full SHA
    f98f1ed View commit details
    Browse the repository at this point in the history

Commits on May 23, 2021

  1. actually a test can be added

    @ConorGriffin37
    ConorGriffin37 committed May 23, 2021
    Configuration menu
    Copy the full SHA
    7ea5eeb View commit details
    Browse the repository at this point in the history

  2. coroutine in test

    @ConorGriffin37
    ConorGriffin37 committed May 23, 2021
    Configuration menu
    Copy the full SHA
    72863ab View commit details
    Browse the repository at this point in the history

  3. Add new better fix

    @ConorGriffin37
    ConorGriffin37 committed May 23, 2021
    Configuration menu
    Copy the full SHA
    c365120 View commit details
    Browse the repository at this point in the history

  4. remove old fix

    @ConorGriffin37
    ConorGriffin37 committed May 23, 2021
    Configuration menu
    Copy the full SHA
    047fb44 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into updateChildrenReEntracyIssue

    @ConorGriffin37
    ConorGriffin37 committed May 23, 2021
    Configuration menu
    Copy the full SHA
    27b2174 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Add temp config and changelog entry

    @ConorGriffin37
    ConorGriffin37 committed May 24, 2021
    Configuration menu
    Copy the full SHA
    945dd57 View commit details
    Browse the repository at this point in the history

  2. set config to false

    @ConorGriffin37
    ConorGriffin37 committed May 24, 2021
    Configuration menu
    Copy the full SHA
    d251a1b View commit details
    Browse the repository at this point in the history

  3. add config.scoped

    @ConorGriffin37
    ConorGriffin37 committed May 24, 2021
    Configuration menu
    Copy the full SHA
    4b69643 View commit details
    Browse the repository at this point in the history

  4. Set parent in replaceVirtualNode too

    @ConorGriffin37
    ConorGriffin37 committed May 24, 2021
    Configuration menu
    Copy the full SHA
    3a12252 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Mention config in changelog

    @ConorGriffin37
    ConorGriffin37 committed May 25, 2021
    Configuration menu
    Copy the full SHA
    1422c09 View commit details
    Browse the repository at this point in the history