This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Remove children when updating a host node to an element with nil children #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused an issue when updating an element that had children - when an element went from having children to having nil children, the rendered objects would not be removed.
|
This change looks good to me, but I want to wait for @ZoteTheMighty. Can we pull benchmark numbers out for this change, too? |
|
This looks okay to me, but I have a couple comments to consider: I did some quick benchmarking, and there's a somewhat consistent 20-25% slowdown on benchmarks for specifically mount and update operations. Note that mounting and updating big nested trees sees a much smaller effect. The performance effect is specifically on the leaves of these element trees. That said, there are a couple things we might be able to do regain some of this performance and still fix the bug.
|
ZoteTheMighty
previously requested changes
May 29, 2019
…al check to resolve the bug.
ZoteTheMighty
requested review from
ZoteTheMighty
and removed request for
ZoteTheMighty
LPGhatguy
suggested changes
May 30, 2019
Co-Authored-By: Lucien Greathouse <me@lpghatguy.com>
LPGhatguy
approved these changes
May 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #209. In ea822f6 we introduced an optimization in RobloxRenderer that avoids calling into the reconciler to update children if the element's children are
nil. This introduced #209, where when updating a tree with an element that hasnilchildren (not an empty table), the existing children are not unmounted.Checklist before submitting:
CHANGELOG.mdAdded/updated documentation