Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Commit

Permalink
Remove undocumented APIs getGlobalConfigValue and Element (#195)
Browse files Browse the repository at this point in the history
* Remove undocumented APIs

* Update CHANGELOG
  • Loading branch information
LPGhatguy committed Apr 29, 2019
1 parent 462ecf7 commit fdf4d39
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
* `setState` can now be called inside `init` and `willUpdate`. Instead of triggering a new render, it will affect the currently scheduled one. ([#139](https://github.com/Roblox/roact/pull/139))
* Roll back changes that allowed `setState` to be called inside `willUpdate`, which created state update scenarios with difficult-to-determine behavior. ([#157](https://github.com/Roblox/roact/pull/157))
* By default, disable the warning for an element changing types during reconciliation ([#168](https://github.com/Roblox/roact/pull/168))
* Removed some undocumented APIs:
* `Roact.getGlobalConfigValue`, which let users read the current internal configuration.
* `Roact.Element`, which let users figure out whether something is a Roact element. We'll introduce a proper type-checking API at a later date.

## 1.0.0 Prerelease 2 (March 22, 2018)
* Removed `is*Element` methods, this is unlikely to affect anyone ([#50](https://github.com/Roblox/roact/pull/50))
Expand Down
2 changes: 0 additions & 2 deletions lib/init.lua
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ local Roact = {
PureComponent = require(script.PureComponent),

Children = Core.Children,
Element = Core.Element,
None = Core.None,
Portal = Core.Portal,
Ref = Core.Ref,
Expand All @@ -32,7 +31,6 @@ local Roact = {
reconcile = ReconcilerCompat.reconcile,

setGlobalConfig = GlobalConfig.set,
getGlobalConfigValue = GlobalConfig.getValue,

-- APIs that may change in the future without warning
UNSTABLE = {
Expand Down
2 changes: 0 additions & 2 deletions lib/init.spec.lua
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ return function()
update = "function",
oneChild = "function",
setGlobalConfig = "function",
getGlobalConfigValue = "function",

-- These functions are deprecated and throw warnings!
reify = "function",
Expand All @@ -25,7 +24,6 @@ return function()
Change = true,
Ref = true,
None = true,
Element = true,
UNSTABLE = true,
}

Expand Down

0 comments on commit fdf4d39

Please sign in to comment.