Added missing parent::setUp() in tests #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Sep 21, 2017
|
Just wondering, that is the motivation for this? Is there any code in parent call? |
|
No, but parent calls should always be there unless the child implementation
can fully guarantee to initialise the parent's state.
The parent implementation can also change, so it isn't a fixed target.
…On 12 Oct 2017 01:05, "Tomáš Votruba" ***@***.***> wrote:
Just wondering, that is the motivation for this?
Is there any code in parent call?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#372 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakCrddDgHpQZC0h5FiiBQlRWTikAMks5srUmlgaJpZM4PfopK>
.
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.