Improve getNamespacedName() return type
#1428
Conversation
staabm
changed the title
ReflectionConstant->getNamespacedName() return typegetNamespacedName() return type
| @@ -49,6 +49,10 @@ | |||
| "conflict": { | |||
| "thecodingmachine/safe": "<1.1.3" | |||
| }, | |||
| "scripts": { | |||
There was a problem hiding this comment.
I am not used to the psalm commands.. have to google them all the time.. added them here to ease contributing for non-psalm experienced people like me
There was a problem hiding this comment.
Not very happy to have composer as a wrapper to run scripts, but it's a non-blocker for this patch
| @@ -49,6 +49,10 @@ | |||
| "conflict": { | |||
| "thecodingmachine/safe": "<1.1.3" | |||
| }, | |||
| "scripts": { | |||
There was a problem hiding this comment.
Not very happy to have composer as a wrapper to run scripts, but it's a non-blocker for this patch
| if ($namespaceName === '') { | ||
| throw new LogicException('Namespace name should never be empty'); | ||
| } |
There was a problem hiding this comment.
Is this something we can test at all? Or is it an upstream type refinement required?
There was a problem hiding this comment.
the upstream type is already refined, but the change itself is not yet released
There was a problem hiding this comment.
Let's then roll with this as-is: a lock file update will expose the type contradiction later on 👍
|
Thanks @staabm! |
triggered by https://github.com/phpstan/phpstan-src/pull/3013/files#r1564724535
refs phpstan/phpstan-src#3013