Merge pull request #1137 from Ride-The-Lightning/Release-0.13.2

Release 0.13.2
Ride-The-Lightning · Nov 22, 2022 · 04f9093 · 04f9093
2 parents cf0cb04 + 57208d1
commit 04f9093
Show file tree

Hide file tree

Showing 407 changed files with 11,131 additions and 5,636 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -34,8 +34,9 @@
         "@angular-eslint/arrow-body-style": "off",
         "@angular-eslint/component-selector": ["error", { "prefix": "rtl", "style": "kebab-case", "type": "element" }],
         "@angular-eslint/directive-selector": ["error", { "style": "camelCase", "type": "attribute" }],
-        "@typescript-eslint/type-annotation-spacing": "error",
         "@typescript-eslint/member-delimiter-style": ["error", { "multiline": { "delimiter": "semi", "requireLast": true}, "singleline": { "delimiter": "comma", "requireLast": false }}],
+        "@typescript-eslint/no-non-null-assertion": "off",        
+        "@typescript-eslint/type-annotation-spacing": "error",
         "quotes": ["error", "single"],
         "comma-dangle": ["error", "never"],
         "comma-spacing": ["error", { "before": false, "after": true }],
@@ -47,7 +48,7 @@
         "curly": "error",
         "no-unused-expressions": "error",
         "strict": "error",
-        "max-len": ["error", { "code": 450 }],
+        "max-len": ["error", { "code": 320 }],
         "no-multiple-empty-lines": "error",
         "no-trailing-spaces": "error",
         "quote-props": ["error", "as-needed"],

diff --git a/.github/README.md b/.github/README.md
@@ -104,6 +104,7 @@ Example RTL-Config.json:
         "bitcoindConfigPath": "<Optional: path of bitcoind.conf path if available locally>",
         "logLevel": "INFO",
         "fiatConversion": false,
+        "unannouncedChannels": false,
         "lnServerUrl": "<url for LND REST APIs for node #1 e.g. https://192.168.0.1:8080>",
         "swapServerUrl": "<url for swap server REST APIs for the node. e.g. https://localhost:8081>",
         "boltzServerUrl": "<url for boltz server REST APIs for the node. e.g. https://localhost:9003>"

diff --git a/.github/docs/Application_configurations.md b/.github/docs/Application_configurations.md
@@ -35,6 +35,7 @@ parameters have `default` values for initial setup and can be updated after RTL
         "logLevel": <logging levels, will log in accordance with the logLevel value provided, Allowed values ERROR, WARN, INFO, DEBUG>,
         "fiatConversion": <parameter to turn fiat conversion off/on. Allowed values - true, false, default false, Required>,
         "currencyUnit": "<Optional: Fiat current Unit for currency conversion, default 'USD' If fiatConversion is true, Required if fiatConversion is true>",
+        "unannouncedChannels": <parameter to turn off/on setting for opening announced Channels, default false, Optional>
         "lnServerUrl": "<Service url for LND/Core Lightning REST APIs for the node, e.g. https://192.168.0.1:8080 OR https://192.168.0.1:3001 OR http://192.168.0.1:8080. Default 'https://localhost:8080', Required",
         "swapServerUrl": "<Service url for swap server REST APIs for the node, e.g. https://localhost:8081, Optional>",
         "boltzServerUrl": "<Service url for boltz server REST APIs for the node, e.g. https://localhost:9003, Optional>"
@@ -66,4 +67,5 @@ RTL_CONFIG_PATH (Path for the folder containing 'RTL-Config.json' file, Required
 BITCOIND_CONFIG_PATH (Full path of the bitcoind.conf file including the file name, Optional)<br />
 CHANNEL_BACKUP_PATH (Folder location for saving the channel backup files, valid for LND implementation only, Required if ln implementation=LND else Optional)<br />
 ENABLE_OFFERS (Boolean flag to enable the offers feature on core lighning, default false, optional)<br />
+ENABLE_PEERSWAP (Boolean flag to enable the peerswap feature on core lighning, default false, optional)<br />
 LN_API_PASSWORD (Password for Eclair implementation if the eclair.conf path is not available, Required if ln implementation=ECL && config path is undefined)<br />
diff --git a/.github/docs/Core_lightning_setup.md b/.github/docs/Core_lightning_setup.md
@@ -82,6 +82,7 @@ Ensure that the follow values are correct per your config:
         "bitcoindConfigPath": "",
         "logLevel": "INFO",
         "fiatConversion": false,
+        "unannouncedChannels": false,
         "lnServerUrl": "https://<cl-rest api server ip address>:3001"
       }
     }

diff --git a/.github/docs/Eclair_setup.md b/.github/docs/Eclair_setup.md
@@ -77,6 +77,7 @@ Ensure that the follow values are correct per your config:
         "bitcoindConfigPath": "",
         "logLevel": "INFO",
         "fiatConversion": false,
+        "unannouncedChannels": false,
         "lnServerUrl": "http://<eclair api server ip address>:port"
       }
     }

diff --git a/.github/docs/RTL_setups.md b/.github/docs/RTL_setups.md
@@ -39,6 +39,7 @@ If your running RTL and LND on different devices on your local LAN, certain conf
         "bitcoindConfigPath": "<Optional: path of bitcoind.conf path if available locally>",
         "logLevel": "INFO",
         "fiatConversion": false,
+        "unannouncedChannels": false,
         "lnServerUrl": "<https://<ip-address-of-device-running-lnd>:8080; e.g. https://192.168.0.1:8080>",
         "swapServerUrl": "<https://<localhost>:8081>",
         "boltzServerUrl": "<https://<localhost>:9003>"

diff --git a/.github/workflows/stats.yml b/.github/workflows/stats.yml
@@ -0,0 +1,23 @@
+name: Pull Request Stats
+
+on:
+  push:
+    branches: [ master, 'Release-*' ]
+    tags: [ 'v*' ]
+  release:
+    types: [released]
+  # Triggers the workflow only when merging pull request to the branches.
+  pull_request:
+    types: [opened, closed]
+    branches: [ master, 'Release-*', '*' ]
+  # Allows you to run this workflow manually from the Actions tab
+  workflow_dispatch:
+
+jobs:
+  stats:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Run pull request stats
+        uses: flowwer-dev/pull-request-stats@master
+        with:
+          period: 365
diff --git a/Sample-RTL-Config.json b/Sample-RTL-Config.json
@@ -27,7 +27,8 @@
         "lnServerUrl": "https://localhost:8080",
         "swapServerUrl": "https://localhost:8081",
         "boltzServerUrl": "https://localhost:9003",
-        "fiatConversion": false
+        "fiatConversion": false,
+        "unannouncedChannels": false
       }
     }
   ]

diff --git a/backend/controllers/cln/getInfo.js b/backend/controllers/cln/getInfo.js
@@ -62,7 +62,7 @@ export const getInfo = (req, res, next) => {
                 req.session.selectedNode.ln_version = body.version || '';
                 logger.log({ selectedNode: req.session.selectedNode, level: 'INFO', fileName: 'GetInfo', msg: 'Connecting to the Core Lightning\'s Websocket Server.' });
                 clWsClient.updateSelectedNode(req.session.selectedNode);
-                databaseService.loadDatabase(req.session.selectedNode);
+                databaseService.loadDatabase(req.session);
                 logger.log({ selectedNode: req.session.selectedNode, level: 'INFO', fileName: 'GetInfo', msg: 'Node Information Received', data: body });
                 return res.status(200).json(body);
             }

diff --git a/backend/controllers/cln/invoices.js b/backend/controllers/cln/invoices.js
@@ -31,10 +31,6 @@ export const listInvoices = (req, res, next) => {
     logger.log({ selectedNode: req.session.selectedNode, level: 'DEBUG', fileName: 'Invoice', msg: 'Invoices List URL', data: options.url });
     request(options).then((body) => {
         logger.log({ selectedNode: req.session.selectedNode, level: 'DEBUG', fileName: 'Invoice', msg: 'Invoices List Received', data: body });
-        if (body.invoices && body.invoices.length > 0) {
-            body.invoices = common.sortDescByKey(body.invoices, 'expires_at');
-        }
-        logger.log({ selectedNode: req.session.selectedNode, level: 'INFO', fileName: 'Invoice', msg: 'Sorted Invoices List Received', data: body });
         res.status(200).json(body);
     }).catch((errRes) => {
         const err = common.handleError(errRes, 'Invoice', 'List Invoices Error', req.session.selectedNode);

diff --git a/backend/controllers/cln/network.js b/backend/controllers/cln/network.js
@@ -78,8 +78,10 @@ export const listNodes = (req, res, next) => {
         body.forEach((node) => {
             var _a, _b;
             if (node.option_will_fund) {
-                node.option_will_fund.lease_fee_base_msat = (node.option_will_fund.lease_fee_base_msat && typeof node.option_will_fund.lease_fee_base_msat === 'string' && node.option_will_fund.lease_fee_base_msat.includes('msat')) ? (_a = node.option_will_fund.lease_fee_base_msat) === null || _a === void 0 ? void 0 : _a.replace('msat', '') : node.option_will_fund.lease_fee_base_msat;
-                node.option_will_fund.channel_fee_max_base_msat = (node.option_will_fund.channel_fee_max_base_msat && typeof node.option_will_fund.channel_fee_max_base_msat === 'string' && node.option_will_fund.channel_fee_max_base_msat.includes('msat')) ? (_b = node.option_will_fund.channel_fee_max_base_msat) === null || _b === void 0 ? void 0 : _b.replace('msat', '') : node.option_will_fund.channel_fee_max_base_msat;
+                node.option_will_fund.lease_fee_base_msat = (node.option_will_fund.lease_fee_base_msat && typeof node.option_will_fund.lease_fee_base_msat === 'string' &&
+                    node.option_will_fund.lease_fee_base_msat.includes('msat')) ? (_a = node.option_will_fund.lease_fee_base_msat) === null || _a === void 0 ? void 0 : _a.replace('msat', '') : node.option_will_fund.lease_fee_base_msat;
+                node.option_will_fund.channel_fee_max_base_msat = (node.option_will_fund.channel_fee_max_base_msat && typeof node.option_will_fund.channel_fee_max_base_msat === 'string' &&
+                    node.option_will_fund.channel_fee_max_base_msat.includes('msat')) ? (_b = node.option_will_fund.channel_fee_max_base_msat) === null || _b === void 0 ? void 0 : _b.replace('msat', '') : node.option_will_fund.channel_fee_max_base_msat;
             }
             return node;
         });

diff --git a/backend/controllers/cln/offers.js b/backend/controllers/cln/offers.js
@@ -11,9 +11,6 @@ export const listOfferBookmarks = (req, res, next) => {
     logger.log({ selectedNode: req.session.selectedNode, level: 'INFO', fileName: 'Offers', msg: 'Getting Offer Bookmarks..' });
     databaseService.find(req.session.selectedNode, CollectionsEnum.OFFERS).then((offers) => {
         logger.log({ selectedNode: req.session.selectedNode, level: 'INFO', fileName: 'Offers', msg: 'Offer Bookmarks Received', data: offers });
-        if (offers && offers.length > 0) {
-            offers = common.sortDescByKey(offers, 'lastUpdatedAt');
-        }
         res.status(200).json(offers);
     }).catch((errRes) => {
         const err = common.handleError(errRes, 'Offers', 'Offer Bookmarks Error', req.session.selectedNode);
@@ -22,7 +19,7 @@ export const listOfferBookmarks = (req, res, next) => {
 };
 export const deleteOfferBookmark = (req, res, next) => {
     logger.log({ selectedNode: req.session.selectedNode, level: 'INFO', fileName: 'Offers', msg: 'Deleting Offer Bookmark..' });
-    databaseService.destroy(req.session.selectedNode, CollectionsEnum.OFFERS, CollectionFieldsEnum.BOLT12, req.params.offerStr).then((deleteRes) => {
+    databaseService.remove(req.session.selectedNode, CollectionsEnum.OFFERS, CollectionFieldsEnum.BOLT12, req.params.offerStr).then((deleteRes) => {
         logger.log({ selectedNode: req.session.selectedNode, level: 'INFO', fileName: 'Offers', msg: 'Offer Bookmark Deleted', data: deleteRes });
         res.status(204).json(req.params.offerStr);
     }).catch((errRes) => {

diff --git a/backend/controllers/cln/onchain.js b/backend/controllers/cln/onchain.js
@@ -44,9 +44,6 @@ export const getUTXOs = (req, res, next) => {
     }
     options.url = req.session.selectedNode.ln_server_url + '/v1/listFunds';
     request(options).then((body) => {
-        if (body.outputs) {
-            body.outputs = common.sortDescByStrKey(body.outputs, 'status');
-        }
         logger.log({ selectedNode: req.session.selectedNode, level: 'INFO', fileName: 'OnChain', msg: 'Funds List Received', data: body });
         res.status(200).json(body);
     }).catch((errRes) => {

diff --git a/backend/controllers/cln/payments.js b/backend/controllers/cln/payments.js
@@ -73,10 +73,6 @@ export const listPayments = (req, res, next) => {
     options.url = req.session.selectedNode.ln_server_url + '/v1/pay/listPayments';
     request(options).then((body) => {
         logger.log({ selectedNode: req.session.selectedNode, level: 'DEBUG', fileName: 'Payments', msg: 'Payment List Received', data: body.payments });
-        if (body && body.payments && body.payments.length > 0) {
-            body.payments = common.sortDescByKey(body.payments, 'created_at');
-        }
-        logger.log({ selectedNode: req.session.selectedNode, level: 'INFO', fileName: 'Payments', msg: 'Sorted Payments List Received', data: body.payments });
         res.status(200).json(groupBy(body.payments));
     }).catch((errRes) => {
         const err = common.handleError(errRes, 'Payments', 'List Payments Error', req.session.selectedNode);
@@ -108,19 +104,25 @@ export const postPayment = (req, res, next) => {
         logger.log({ selectedNode: req.session.selectedNode, level: 'INFO', fileName: 'Payments', msg: 'Payment Sent', data: body });
         if (req.body.paymentType === 'OFFER') {
             if (req.body.saveToDB && req.body.bolt12) {
-                const offerToUpdate = { bolt12: req.body.bolt12, amountmSat: (req.body.zeroAmtOffer ? 0 : req.body.amount), title: req.body.title, lastUpdatedAt: new Date(Date.now()).getTime() };
+                const offerToUpdate = { bolt12: req.body.bolt12, amountMSat: (req.body.zeroAmtOffer ? 0 : req.body.amount), title: req.body.title, lastUpdatedAt: new Date(Date.now()).getTime() };
                 if (req.body.vendor) {
                     offerToUpdate['vendor'] = req.body.vendor;
                 }
                 if (req.body.description) {
                     offerToUpdate['description'] = req.body.description;
                 }
-                return databaseService.update(req.session.selectedNode, CollectionsEnum.OFFERS, offerToUpdate, CollectionFieldsEnum.BOLT12, req.body.bolt12).then((updatedOffer) => {
-                    logger.log({ level: 'DEBUG', fileName: 'Offer', msg: 'Offer Updated', data: updatedOffer });
-                    return res.status(201).json({ paymentResponse: body, saveToDBResponse: updatedOffer });
-                }).catch((errDB) => {
-                    logger.log({ selectedNode: req.session.selectedNode, level: 'ERROR', fileName: 'Payments', msg: 'Offer DB update error', error: errDB });
-                    return res.status(201).json({ paymentResponse: body, saveToDBError: errDB });
+                // eslint-disable-next-line arrow-body-style
+                return databaseService.validateDocument(CollectionsEnum.OFFERS, offerToUpdate).then((validated) => {
+                    return databaseService.update(req.session.selectedNode, CollectionsEnum.OFFERS, offerToUpdate, CollectionFieldsEnum.BOLT12, req.body.bolt12).then((updatedOffer) => {
+                        logger.log({ level: 'DEBUG', fileName: 'Payments', msg: 'Offer Updated', data: updatedOffer });
+                        return res.status(201).json({ paymentResponse: body, saveToDBResponse: updatedOffer });
+                    }).catch((errDB) => {
+                        logger.log({ selectedNode: req.session.selectedNode, level: 'ERROR', fileName: 'Payments', msg: 'Offer DB update error', error: errDB });
+                        return res.status(201).json({ paymentResponse: body, saveToDBError: errDB });
+                    });
+                }).catch((errValidation) => {
+                    logger.log({ selectedNode: req.session.selectedNode, level: 'ERROR', fileName: 'Payments', msg: 'Offer DB validation error', error: errValidation });
+                    return res.status(201).json({ paymentResponse: body, saveToDBError: errValidation });
                 });
             }
             else {

diff --git a/backend/controllers/cln/peers.js b/backend/controllers/cln/peers.js
@@ -17,9 +17,8 @@ export const getPeers = (req, res, next) => {
                 peer.alias = peer.id.substring(0, 20);
             }
         });
-        const peers = (body) ? common.sortDescByStrKey(body, 'alias') : [];
-        logger.log({ selectedNode: req.session.selectedNode, level: 'INFO', fileName: 'Peers', msg: 'Peers with Alias Received', data: peers });
-        res.status(200).json(peers);
+        logger.log({ selectedNode: req.session.selectedNode, level: 'INFO', fileName: 'Peers', msg: 'Peers with Alias Received', data: body });
+        res.status(200).json(body || []);
     }).catch((errRes) => {
         const err = common.handleError(errRes, 'Peers', 'List Peers Error', req.session.selectedNode);
         return res.status(err.statusCode).json({ message: err.message, error: err.error });
@@ -33,12 +32,11 @@ export const postPeer = (req, res, next) => {
     }
     options.url = req.session.selectedNode.ln_server_url + '/v1/peer/connect';
     options.body = req.body;
-    request.post(options).then((body) => {
-        logger.log({ selectedNode: req.session.selectedNode, level: 'DEBUG', fileName: 'Peers', msg: 'Peer Connected', data: body });
+    request.post(options).then((connectRes) => {
+        logger.log({ selectedNode: req.session.selectedNode, level: 'DEBUG', fileName: 'Peers', msg: 'Peer Connected', data: connectRes });
         options.url = req.session.selectedNode.ln_server_url + '/v1/peer/listPeers';
-        request(options).then((body) => {
-            let peers = (body) ? common.sortDescByStrKey(body, 'alias') : [];
-            peers = common.newestOnTop(peers, 'id', req.body.id);
+        request(options).then((listPeersRes) => {
+            const peers = listPeersRes ? common.newestOnTop(listPeersRes, 'id', req.body.id) : [];
             logger.log({ selectedNode: req.session.selectedNode, level: 'INFO', fileName: 'Peers', msg: 'Peers List after Connect Received', data: peers });
             res.status(201).json(peers);
         }).catch((errRes) => {

diff --git a/backend/controllers/eclair/channels.js b/backend/controllers/eclair/channels.js
@@ -13,10 +13,10 @@ export const simplifyAllChannels = (selNode, channels) => {
             nodeId: channel.nodeId ? channel.nodeId : '',
             channelId: channel.channelId ? channel.channelId : '',
             state: channel.state ? channel.state : '',
-            channelFlags: channel.data && channel.data.commitments && channel.data.commitments.channelFlags ? channel.data.commitments.channelFlags : 0,
+            announceChannel: channel.data && channel.data.commitments && channel.data.commitments.channelFlags && channel.data.commitments.channelFlags.announceChannel ? channel.data.commitments.channelFlags.announceChannel : false,
             toLocal: (channel.data.commitments.localCommit.spec.toLocal) ? Math.round(+channel.data.commitments.localCommit.spec.toLocal / 1000) : 0,
             toRemote: (channel.data.commitments.localCommit.spec.toRemote) ? Math.round(+channel.data.commitments.localCommit.spec.toRemote / 1000) : 0,
-            shortChannelId: channel.data && channel.data.shortChannelId ? channel.data.shortChannelId : '',
+            shortChannelId: channel.data && channel.data.channelUpdate && channel.data.channelUpdate.shortChannelId ? channel.data.channelUpdate.shortChannelId : '',
             isFunder: channel.data && channel.data.commitments && channel.data.commitments.localParams && channel.data.commitments.localParams.isFunder ? channel.data.commitments.localParams.isFunder : false,
             buried: channel.data && channel.data.buried ? channel.data.buried : false,
             feeBaseMsat: channel.data && channel.data.channelUpdate && channel.data.channelUpdate.feeBaseMsat ? channel.data.channelUpdate.feeBaseMsat : 0,

diff --git a/backend/controllers/eclair/fees.js b/backend/controllers/eclair/fees.js
@@ -88,9 +88,6 @@ export const arrangePayments = (selNode, body) => {
             relayedEle.amountOut = Math.round(relayedEle.amountOut / 1000);
         }
     });
-    payments.sent = common.sortDescByKey(payments.sent, 'firstPartTimestamp');
-    payments.received = common.sortDescByKey(payments.received, 'firstPartTimestamp');
-    payments.relayed = common.sortDescByKey(payments.relayed, 'timestamp');
     logger.log({ selectedNode: selNode, level: 'DEBUG', fileName: 'Fees', msg: 'Arranged Payments Received', data: payments });
     return payments;
 };

diff --git a/backend/controllers/eclair/getInfo.js b/backend/controllers/eclair/getInfo.js
@@ -38,11 +38,11 @@ export const getInfo = (req, res, next) => {
                 body.lnImplementation = 'Eclair';
                 req.session.selectedNode.ln_version = body.version.split('-')[0] || '';
                 eclWsClient.updateSelectedNode(req.session.selectedNode);
-                databaseService.loadDatabase(req.session.selectedNode);
+                databaseService.loadDatabase(req.session);
                 logger.log({ selectedNode: req.session.selectedNode, level: 'INFO', fileName: 'GetInfo', msg: 'Node Information Received', data: body });
                 return res.status(200).json(body);
             }).catch((errRes) => {
-                const err = common.handleError(errRes, 'GetInfo', 'Get Info Error', req);
+                const err = common.handleError(errRes, 'GetInfo', 'Get Info Error', req.session.selectedNode);
                 return res.status(err.statusCode).json({ message: err.message, error: err.error });
             });
         }