R&Y: Updated PDX hop fastpass and Added HID AIDs to aid_desfire.json #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Updated PDX hop fastpass** - *Updated name and description to use its correct name/stylisation.* **Added HID AIDs** - *Based on information obtained within the Discord Server, with many thanks.* - *SIO EV3 HID Factory AID added.* - *SIO EV3 Field Encoder AID added.* **Updated PACS AIDs** -*Updated several name and descriptions to improve output consistency.* Many thanks in advance, and kind regards, -randy. Signed-off-by: ry4000 <154689120+ry4000@users.noreply.github.com>
|
You are welcome to add an entry to the CHANGELOG.md as well |
|
I believe just say "Ev1" to be misdirecting, I recommend you use "DESFire Ev1" in the name. |
Per Iceman's feedback, `SIO DESFire EV1` / `SIO DESFire EV3` to ensure clarity rather than the ambiguous `SIO EV1` and `SIO EV3`. Signed-off-by: ry4000 <154689120+ry4000@users.noreply.github.com>
|
Recommendation implemented with apologies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated PDX hop fastpass
Added HID AIDs
Updated PACS AIDs
hf mfdes lsapp --no-authcommand output consistency.Many thanks in advance, and kind regards,
-randy.