Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hitag S get uid #2510

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Fix Hitag S get uid #2510

merged 3 commits into from
Sep 15, 2024

Conversation

douniwan5788
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

You are welcome to add an entry to the CHANGELOG.md as well

iceman1001
iceman1001 reviewed Sep 15, 2024
View reviewed changes
armsrc/hitagS.c
@@ -1226,7 +1211,7 @@ static int hts_select_tag(const lf_hitag_data_t *packet, uint8_t *tx, size_t siz
hts_send_receive(tx, txlen, rx, sizeofrx, &rxlen, t_wait, ledcontrol, true);

if (rxlen != 32) {
DBG DbpString("UID Request failed!");
DbpString("UID Request failed!");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

place back the DBG guard

@iceman1001
Copy link
Collaborator

Looks like you fixing simulation code, rdbl code , em41x0 code in one PR. I don't see get_uid being fixed?

Regarding DBG guard:
We are not using the device side to actively return strings and inform the user since long ago.
The hitag code base hasn't been updated to match that. We put the Extended debug around them otherwise they will blurt out in the client like in lf search when not a hitag tag is used.

The preferred way to communicate is by sending status packages to the client, which will handle the printing

@douniwan5788
Copy link
Contributor Author

Looks like you fixing simulation code, rdbl code , em41x0 code in one PR. I don't see get_uid being fixed?

Regarding DBG guard: We are not using the device side to actively return strings and inform the user since long ago. The hitag code base hasn't been updated to match that. We put the Extended debug around them otherwise they will blurt out in the client like in lf search when not a hitag tag is used.

The preferred way to communicate is by sending status packages to the client, which will handle the printing

OK, let's fix it for good

@iceman1001 iceman1001 merged commit c9531ae into RfidResearchGroup:master Sep 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iceman1001 iceman1001 iceman1001 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douniwan5788 @iceman1001