Changed to use callback function

CHANGELOG.md

@@ -1,5 +1,16 @@
 Version numbers correspond to `bower.json` version
 
+# 0.0.6
+
+## Features
+* Switched to passing callback function rather than two way binding with object in scope
+
+## Bug Fixes
+
+## Breaking Changes
+* Not requires passing of callback function which receives a copy of the oauthUser object previously shared with two way data binding
+
+
 # 0.0.5
 
 ## Features

README.md

@@ -22,20 +22,21 @@ Just add the following directive:
 
 ```html
 	<div drr-oauthio-login
-		data-oauth-user="oauthUser"
+		data-on-login="login(endpoint,user,provider,error)"
 		data-oauth-provider="github"
 		data-provider-icon="github-alt"  // optional
 		data-oauthio-key="<your public OAuth.io key>">
 	</div>
 ```
 
-You can extract information from the oauthUser after successful authentication such as:
+After login, the onLogin callback function will be called. You can extract information from the returned user object after successful authentication such as:
 
 ```html
-<h1>Logged in as {{oauthUser.user.name}}</h1>
+<h1>Logged in as {{user.name}}</h1>
 ```
 
-Our use oauthUser.endpoint to make manual OAuth calls to the provider API.
+Use the returned endpoint object to make manual OAuth calls to the provider API.
+
 
 ## Testing
 

bower.json

@@ -1,6 +1,6 @@
 {
 	"name": "angular-oauthio-login",
-	"version": "0.0.5",
+	"version": "0.0.6",
 	"authors": [
 		"David Resseguie <david@resseguie.com>"
 	],

index.html

@@ -30,19 +30,19 @@ <h1>angular-oauthio-login test</h1>
 
 			<div class="alert alert-danger" ng-show="keyError">You have to enter your OAuth.io public key for the test app to work!</div>
 
+			<h2 ng-show="oauthUser.user">Logged in user: {{oauthUser.user.name}}</h2>
+			<h2 ng-show="oauthUser.error">Error: {{oauthUser.error.message}}</h2>
+			<div ng-show="oauthUser"><a ng-click="oauthUser = null">Log out</a></div>
+
+
 			<div ng-repeat="(provider,icon) in providers">
 				<h2>{{provider}}</h2>
 				<div drr-oauthio-login
-					data-oauth-user="oauthUser"
+					data-on-login="login(endpoint,user,provider,error)"
 					data-oauth-provider="{{provider}}"
 					data-provider-icon="{{icon}}"
 					data-oauthio-key="{{oauthioKey}}">
 				</div>
-
-				<h2 ng-show="oauthUser.user">Logged in user: {{oauthUser.user.name}}</h2>
-				<h2 ng-show="oauthUser.error">Error: {{oauthUser.error.message}}</h2>
-				<div ng-show="oauthUser"><a ng-click="oauthUser = null">Log out</a></div>
-
 			</div>
 
 			<script src="bower_components/jquery/dist/jquery.js"></script>
@@ -71,7 +71,16 @@ <h2 ng-show="oauthUser.error">Error: {{oauthUser.error.message}}</h2>
 
 					$scope.$watch('oauthioKey',function(value){
 						$scope.keyError = (value == '<your public OAuth.io key here>');
-					})
+					});
+
+					$scope.login = function(endpoint,user,provider,error){
+						$scope.oauthUser = {
+							endpoint: endpoint,
+							user: user,
+							provider: provider,
+							error: error
+						};
+					}
 				}]);
 			</script>
 

oauthio-login.js

@@ -53,7 +53,7 @@ angular.module('resseguie.angular-oauthio-login', [])
 							'</button>'+
 						'</div>',
 			scope : {
-				oauthUser     : "=", // model to store the results
+				onLogin       : "&", // callback function
 				oauthioKey    : "@", // OAuthi.io public key
 				oauthProvider : "@", // OAuth provider to authenticate with
 				providerIcon  : "@"  // optional Font Awesome icon name to use
@@ -75,14 +75,15 @@ angular.module('resseguie.angular-oauthio-login', [])
 							oauthUser.user     = result.user;
 							oauthUser.provider = scope.oauthProvider;
 							oauthUser.error    = null;
-							scope.oauthUser    = oauthUser;
+							scope.onLogin(oauthUser);
 						},function(error){
 							var oauthUser = {};
 							oauthUser.endpoint = null;
 							oauthUser.user     = null;
 							oauthUser.error    = error;
 							oauthUser.provider = scope.oauthProvider;
 							scope.oauthUser    = oauthUser;
+							scope.onLogin(oauthUser);
 						});
 					}
 				};