Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mkdocs #53

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

abhishekpcnair
Copy link

#49 Ported from sphinx to mkdocs material theme

@ramnes
Copy link
Member

ramnes commented Feb 10, 2024

Hey, thanks for your work! Is the result visible somewhere?

One important thing: we shouldn't have the mkdocs output (minified files and such) in the repository. Instead we should use a GitHub action and push that output in a branch.

You can have a look here at how we've done it for notion-sdk-py, specifically the .github/workflows/docs.yml file: ramnes/notion-sdk-py#30

@abhishekpcnair
Copy link
Author

Noted I will fix them, but the docs with sphinx right now is hosted in readthedocs right? If so, then something like this should work https://about.readthedocs.com/tools/mkdocs/

@abhishekpcnair
Copy link
Author

Not very familiar with the GH, but after some trial and error, here it is
https://abhishekpcnair.github.io/mongo-thingy/

The order of sections need some work though, but this could be a good starting point

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 176c97b on abhishekpcnair:feature/mkdocs
into 879fd7c on Refty:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants