Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cluster support for mongodb write behind #94

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Nov 29, 2021

Adding the ability to create custom mongodb:// style connection strings. This adds support for mongo clusters, and even Atlas

MeirShpilraien
MeirShpilraien previously approved these changes Nov 30, 2021
Copy link
Collaborator

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my only comment is that maybe we want to follow the path of allow giving a callback for connection string so it can be read from db configuration, looks here:

return self._user() if callable(self._user) else self._user

@chayim
Copy link
Contributor Author

chayim commented Nov 30, 2021

Looks good, my only comment is that maybe we want to follow the path of allow giving a callback for connection string so it can be read from db configuration, looks here:

return self._user() if callable(self._user) else self._user

Does anyone use this? I saw the idea and thought... I'd rather not embed a DSN in a database. For the record I could understand embedding it in a redis key (interesting?).

@chayim chayim merged commit f1abe20 into master Nov 30, 2021
@chayim chayim deleted the ck-clustermongos branch November 30, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants