-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json,mongo #73
json,mongo #73
Conversation
tox postresql
still needs tests and validation
This pull request introduces 7 alerts when merging d951d84 into 1377965 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Some small comments, the most important are the events you need to register on.
This pull request introduces 7 alerts when merging e2de52b into 1377965 - view on LGTM.com new alerts:
|
This pull request introduces 7 alerts when merging 8082131 into 1377965 - view on LGTM.com new alerts:
|
This pull request introduces 7 alerts when merging c62a24c into 1377965 - view on LGTM.com new alerts:
|
This pull request introduces 7 alerts when merging ee7b0d0 into 1377965 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only reviewed the code parts (without the build system changes), maybe @rafie will want to go over the build system.
No description provided.