Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json,mongo #73

Merged
merged 63 commits into from
Sep 29, 2021
Merged

json,mongo #73

merged 63 commits into from
Sep 29, 2021

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Sep 14, 2021

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Sep 14, 2021

This pull request introduces 7 alerts when merging d951d84 into 1377965 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Testing equality to None
  • 1 for Module is imported more than once
  • 1 for Unused local variable
  • 1 for Missing call to `__init__` during object initialization
  • 1 for 'import *' may pollute namespace

Copy link
Collaborator

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Some small comments, the most important are the events you need to register on.

@lgtm-com
Copy link

lgtm-com bot commented Sep 27, 2021

This pull request introduces 7 alerts when merging e2de52b into 1377965 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Testing equality to None
  • 1 for Module is imported more than once
  • 1 for Unused local variable
  • 1 for Missing call to `__init__` during object initialization
  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2021

This pull request introduces 7 alerts when merging 8082131 into 1377965 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Testing equality to None
  • 1 for Module is imported more than once
  • 1 for Unused local variable
  • 1 for Missing call to `__init__` during object initialization
  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2021

This pull request introduces 7 alerts when merging c62a24c into 1377965 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Testing equality to None
  • 1 for Module is imported more than once
  • 1 for Unused local variable
  • 1 for Missing call to `__init__` during object initialization
  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2021

This pull request introduces 7 alerts when merging ee7b0d0 into 1377965 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Testing equality to None
  • 1 for Module is imported more than once
  • 1 for Unused local variable
  • 1 for Missing call to `__init__` during object initialization
  • 1 for 'import *' may pollute namespace

Copy link
Collaborator

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed the code parts (without the build system changes), maybe @rafie will want to go over the build system.

@chayim chayim merged commit 4dccaa8 into master Sep 29, 2021
@chayim chayim deleted the ck-json-on-mongo branch September 29, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants