Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'exactly once' MySQL execution error #57

Merged
merged 3 commits into from
May 23, 2021

Conversation

shankai
Copy link
Contributor

@shankai shankai commented Apr 27, 2021

No description provided.

@@ -207,7 +207,7 @@ def GetUpdateQuery(tableName, mappings, pk):
self.addQuery = GetUpdateQuery(self.tableName, mappings, self.pk)
self.delQuery = 'delete from %s where %s=:%s' % (self.tableName, self.pk, self.pk)
if self.exactlyOnceTableName is not None:
self.exactlyOnceQuery = GetUpdateQuery(self.exactlyOnceTableName, {'val', 'val'}, 'id')
self.exactlyOnceQuery = GetUpdateQuery(self.exactlyOnceTableName, {'val': 'val'}, 'id')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

Copy link
Collaborator

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shankai
Small question...

@CLAassistant
Copy link

CLAassistant commented May 23, 2021

CLA assistant check
All committers have signed the CLA.

@MeirShpilraien
Copy link
Collaborator

@shankai can you sign the CLA?

@shankai
Copy link
Contributor Author

shankai commented May 23, 2021

@shankai can you sign the CLA?

OK, I've signed it.

@MeirShpilraien MeirShpilraien merged commit 537ea77 into RedisGears:master May 23, 2021
@MeirShpilraien
Copy link
Collaborator

Thanks @shankai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants