Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lgtm tag and fixes #21

Merged
merged 3 commits into from
Oct 13, 2020
Merged

lgtm tag and fixes #21

merged 3 commits into from
Oct 13, 2020

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Oct 13, 2020

No description provided.

@ashtul ashtul requested a review from gkorland October 13, 2020 07:31
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #21 into master will decrease coverage by 0.41%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   98.80%   98.39%   -0.42%     
==========================================
  Files           2        2              
  Lines         417      435      +18     
==========================================
+ Hits          412      428      +16     
- Misses          5        7       +2     
Impacted Files Coverage Δ
redisbloom/client.py 98.11% <ø> (+0.05%) ⬆️
test_commands.py 98.82% <92.30%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62144f5...6a50108. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Oct 13, 2020

This pull request fixes 2 alerts when merging d3ddeb2 into 62144f5 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Oct 13, 2020

This pull request fixes 2 alerts when merging 984ff24 into 62144f5 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

filipecosta90
filipecosta90 previously approved these changes Oct 13, 2020
Copy link

@filipecosta90 filipecosta90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just the EOL missing

redisbloom/client.py Outdated Show resolved Hide resolved
test_commands.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Oct 13, 2020

This pull request fixes 2 alerts when merging 6a50108 into 62144f5 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@ashtul ashtul merged commit 3b16fdc into master Oct 13, 2020
@ashtul ashtul deleted the fix-lgtm branch October 13, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants