Rewrite for RN 0.50+ #151

jasonfma · 2017-11-05T20:59:48Z

Major upgrade that supports 0.50+

support by adding reactNativeVersion and DeviceInfo properties to the NativeModules
Remove Navigator test as it was removed from RN
Fix BackAndroid and add BackHandler tests
update all packages
fix lint issues
drop support for Node 4

NOTE: This is a PR into the existing rewrite branch

- update enzyme and use enzyme's react 16 adapter - add RN and react devDeps for now (reflects the peerDeps) - Add newly required `reactNativeVersion` and `DeviceInfo` properties to the `NativeModules` - `reactNativeVersion` reads from the RN source - `DeviceInfo` is set to iPhone 6

- BackAndroid is deprecated by BackHandler - added test for BackHandler - Remove obsolete test of `addEventListener().remove()`

- backwards compatible changes for RN 0.50 - RN 0.50 adds attributes to components and breaks the buildComponentHTML approach to testing

- TODO lint fixes

- remove unnecessary assertion because it's asserted implicitly in the next assertion

Signed-off-by: Jason Ma <jason@peartherapeutics.com>

- render of `ProgressBarAndroid` changed from `ActivityIndicator` in RN 0.49 back to `AndroidProgressBar` in RN 0.50 Signed-off-by: Jason Ma <jason@peartherapeutics.com>

jasonfma · 2017-11-06T03:02:50Z

Changing to support RN 0.50+ because the AndroidProgressBar had a breaking change in RN 0.49 that was fixed in RN 0.50. Rather than start off backwards compatible with 0.49, just do 0.50+.

Signed-off-by: Jason Ma <jason@peartherapeutics.com>

jasonfma · 2017-11-06T03:15:09Z

Dropping support for Node 4. https://travis-ci.org/RealOrangeOne/react-native-mock/jobs/297785954

dusave · 2017-11-09T18:07:18Z

Should probably add react, react-dom, and react-native as dev dependencies also. When trying to build locally without those packages, it fails

RealOrangeOne · 2017-11-10T08:45:46Z

Initial skim looks good. Would probably be ideal to update the README stating that we've dropped support for Node <6 (and why?). Will give it a proper review soon, but glad to see the tests are passing!

gabceb · 2017-11-10T17:53:02Z

Looking forward to this @RealOrangeOne and @jasonfma. When I try to pull this branch as a dev dependency for my project running RN 0.50 and React 16 it complains when running haste.js as part of the post install

Error: EISDIR: illegal operation on a directory, read
    at Error (native)
    at Object.fs.readSync (fs.js:731:19)
    at tryReadSync (fs.js:486:20)
    at Object.fs.readFileSync (fs.js:534:19)
    at /Users/gabrielcebrian/Projects/tes/mobile/app-job-mobile/node_modules/react-native-mock/src/haste.js:32:39
    at Function._.each._.forEach (/Users/gabrielcebrian/Projects/tes/mobile/app-job-mobile/node_modules/underscore/underscore.js:153:9)
    at Object.<anonymous> (/Users/gabrielcebrian/Projects/tes/mobile/app-job-mobile/node_modules/react-native-mock/src/haste.js:31:3)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)

If I clone the project on a different folder the post-install finishes as expected

EdenGottlieb · 2017-12-02T17:59:23Z

Adding a mock for FlatList would be a great idea, in my opinion.

RealOrangeOne

Overall looks pretty good, a couple small comments. Amazing work! 🎉

RealOrangeOne · 2017-12-05T17:22:21Z

.travis.yml

  - "6"
+  - "8"


Could we keep the base versions here too, so add 8.0.0

Should we use 8.9.1 as that is the LTS version?

Using 8 specifically targets the latest release at build time, which is fine. I quite like the idea of testing against the base version as well

RealOrangeOne · 2017-12-05T17:24:07Z

tests/integration/apis/Easing.test.js

@@ -14,7 +14,7 @@ import { expect } from 'chai';
 describe('Easing', () => {
  const { Easing } = require('react-native');

-  it('should have all functions', function () {
+  it('should have all functions', () => {


Please revert changes like this back. function is correct here

Arrow functions should be just fine. You're using them above on line 14 already. Is there something I'm missing?

Sorry, this change was part of the eslint rule update. I just wholesale applied the rule fixes. I can revert, but do you have more context as to why this one needs to be function?

I assumed all were using function, in that case this is totally fine

jasonfma · 2017-12-05T17:57:17Z

@RealOrangeOne just to be clear, this is a PR into the rewrite branch that you created. This is not a merge into master.

- Update readme to reference Node 6 support - Update travis to include Node 8.0.0 tests

jasonfma · 2018-01-06T20:38:37Z

@RealOrangeOne Looks like node 8.0.0 is broken. I'm going to set to 8.9.1 since it's the first LTS version.

RealOrangeOne · 2018-01-06T20:39:57Z

Just seen the build log, agreed that's very weird. I think sticking to that version will probably be fine, it's early enough!

jasonfma · 2018-01-07T02:13:31Z

@RealOrangeOne can you rebuild? I think it failed because of https://github.com/npm/registry/issues/255

jasonfma · 2018-01-07T21:09:24Z

dustinsavery commented on Nov 9, 2017
Should probably add react, react-dom, and react-native as dev dependencies also. When trying to build locally without those packages, it fails

I think this is set up this way so the build can test with various versions of each. I did add them as peerDeps so you can see the warnings.

@RealOrangeOne comments addressed

jasonfma · 2018-01-16T17:18:53Z

@RealOrangeOne will you have some time soon to take a look? I'm happy to help here where I can too. This PR is to merge into your existing rewrite branch #120 where there are still some merge conflicts to resolve as well - so this is not final or going into master.

RealOrangeOne · 2018-01-16T21:02:06Z

All these changes look good to me! Let's get this into rewrite and see how it affects it!

lalop · 2018-02-05T11:18:46Z

I tried rewrite branch but I get this error

Cannot find module './build/react-native-mock.js' from 'mock.js'

Will we use this branch as master ?

RealOrangeOne · 2018-02-05T11:20:04Z

If you're downloading straight from GitHub, you'll have to build the compiled code to actually use it.

Yes, this code will eventually be pushed into master. Time frame unknown, but shouldn't be too long!

lalop · 2018-02-05T11:21:25Z

I get it via yarn, but build folder isn't present.
Is that normal ?

RealOrangeOne · 2018-02-05T11:31:13Z

Yarn, npm, makes no difference. We don't commit the build/ directory for obviousl reasons, committing build artifacts is bad practice. If you want to use a version from somewhere other than npm, you'll need to run the build yourself from the project directory, else you'll only have the source files, which won't work.

lalop · 2018-02-05T11:36:50Z

I'm agree with you but I'm not sure to understand.
I get react-native-mock via yarn, that provide source code not built but https://github.com/RealOrangeOne/react-native-mock/blob/rewrite/mock.js call ./build/react-native-mock.js so is there something wrong here or should I build the package even if I get it via npm/yarn ?

RealOrangeOne · 2018-02-05T11:39:59Z

hmm, this sounds odd, and probably not the best place to discuss. Perhaps raise an actual issue so it can be looked into properly

lalop · 2018-02-05T12:51:31Z

done #157

jasonfma changed the title ~~Rewrite~~ Rewrite for RN 0.49+ Nov 5, 2017

Jason Ma added 11 commits November 5, 2017 13:09

Fix BackAndroid and add BackHandler

513d44a

- BackAndroid is deprecated by BackHandler - added test for BackHandler - Remove obsolete test of `addEventListener().remove()`

Remove Navigator test as it was removed from RN

84cb37b

Fix Dimensions test

d8e6869

Fix tests for Android progress bar and NativeModules Dimensions

43c045a

Update for RN 0.50

f005766

- backwards compatible changes for RN 0.50 - RN 0.50 adds attributes to components and breaks the buildComponentHTML approach to testing

Package updates

4256a3d

- TODO lint fixes

Automatic lint fixes

4fcf080

Manual lint fixes

a15c31e

Fix test broken by chai upgrade

e7b2d15

- remove unnecessary assertion because it's asserted implicitly in the next assertion

More package updates

36f18ea

jasonfma force-pushed the rewrite branch from 81d595d to 36f18ea Compare November 5, 2017 21:10

jasonfma mentioned this pull request Nov 5, 2017

Rewrite #120

Open

9 tasks

Jason Ma added 3 commits November 5, 2017 13:19

Update travis to test RN 0.49+

014cde7

Signed-off-by: Jason Ma <jason@peartherapeutics.com>

Remove react-addons-test-utils from travis builds

6aa7840

Use RN 0.50+

f1b2f25

- render of `ProgressBarAndroid` changed from `ActivityIndicator` in RN 0.49 back to `AndroidProgressBar` in RN 0.50 Signed-off-by: Jason Ma <jason@peartherapeutics.com>

jasonfma changed the title ~~Rewrite for RN 0.49+~~ Rewrite for RN 0.50+ Nov 6, 2017

Jason Ma added 4 commits November 5, 2017 19:03

Add tests for Node 8 now that it's LTS

9d8ff3b

Signed-off-by: Jason Ma <jason@peartherapeutics.com>

Add back devDeps for RN and react to fix build

669d461

Signed-off-by: Jason Ma <jason@peartherapeutics.com>

Fix CI to not rely on devDeps react and react-native

ad2ced5

Signed-off-by: Jason Ma <jason@peartherapeutics.com>

Drop support for Node 4

9d48815

Signed-off-by: Jason Ma <jason@peartherapeutics.com>

gabceb mentioned this pull request Nov 10, 2017

Cannot find module 'react/lib/ReactComponentTreeHook' kodefox/mocha-react-native#1

Open

RealOrangeOne suggested changes Dec 5, 2017

View reviewed changes

Node support

e70acd5

- Update readme to reference Node 6 support - Update travis to include Node 8.0.0 tests

Set base Node 8 test version to 8.9.1

e4b98c6

RealOrangeOne mentioned this pull request Jan 11, 2018

Update to Support React 16 #156

Closed

RealOrangeOne approved these changes Jan 16, 2018

View reviewed changes

RealOrangeOne merged commit 5df69b0 into RealOrangeOne:rewrite Jan 16, 2018

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewrite for RN 0.50+ #151

Rewrite for RN 0.50+ #151

jasonfma commented Nov 5, 2017 •

edited

Loading

jasonfma commented Nov 6, 2017 •

edited

Loading

jasonfma commented Nov 6, 2017

dusave commented Nov 9, 2017

RealOrangeOne commented Nov 10, 2017

gabceb commented Nov 10, 2017

EdenGottlieb commented Dec 2, 2017

RealOrangeOne left a comment

RealOrangeOne Dec 5, 2017

jasonfma Dec 5, 2017

RealOrangeOne Dec 23, 2017

RealOrangeOne Dec 5, 2017

dusave Dec 5, 2017

jasonfma Dec 5, 2017

RealOrangeOne Dec 23, 2017

jasonfma commented Dec 5, 2017

jasonfma commented Jan 6, 2018

RealOrangeOne commented Jan 6, 2018

jasonfma commented Jan 7, 2018

jasonfma commented Jan 7, 2018

jasonfma commented Jan 16, 2018 •

edited

Loading

RealOrangeOne commented Jan 16, 2018

lalop commented Feb 5, 2018

RealOrangeOne commented Feb 5, 2018

lalop commented Feb 5, 2018

RealOrangeOne commented Feb 5, 2018

lalop commented Feb 5, 2018

RealOrangeOne commented Feb 5, 2018 •

edited

Loading

lalop commented Feb 5, 2018

Rewrite for RN 0.50+ #151

Rewrite for RN 0.50+ #151

Conversation

jasonfma commented Nov 5, 2017 • edited Loading

jasonfma commented Nov 6, 2017 • edited Loading

jasonfma commented Nov 6, 2017

dusave commented Nov 9, 2017

RealOrangeOne commented Nov 10, 2017

gabceb commented Nov 10, 2017

EdenGottlieb commented Dec 2, 2017

RealOrangeOne left a comment

Choose a reason for hiding this comment

RealOrangeOne Dec 5, 2017

Choose a reason for hiding this comment

jasonfma Dec 5, 2017

Choose a reason for hiding this comment

RealOrangeOne Dec 23, 2017

Choose a reason for hiding this comment

RealOrangeOne Dec 5, 2017

Choose a reason for hiding this comment

dusave Dec 5, 2017

Choose a reason for hiding this comment

jasonfma Dec 5, 2017

Choose a reason for hiding this comment

RealOrangeOne Dec 23, 2017

Choose a reason for hiding this comment

jasonfma commented Dec 5, 2017

jasonfma commented Jan 6, 2018

RealOrangeOne commented Jan 6, 2018

jasonfma commented Jan 7, 2018

jasonfma commented Jan 7, 2018

jasonfma commented Jan 16, 2018 • edited Loading

RealOrangeOne commented Jan 16, 2018

lalop commented Feb 5, 2018

RealOrangeOne commented Feb 5, 2018

lalop commented Feb 5, 2018

RealOrangeOne commented Feb 5, 2018

lalop commented Feb 5, 2018

RealOrangeOne commented Feb 5, 2018 • edited Loading

lalop commented Feb 5, 2018

jasonfma commented Nov 5, 2017 •

edited

Loading

jasonfma commented Nov 6, 2017 •

edited

Loading

jasonfma commented Jan 16, 2018 •

edited

Loading

RealOrangeOne commented Feb 5, 2018 •

edited

Loading