Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(utils): rename Notification to StreamNotification, Kind to NotificationKind #731

Merged
merged 6 commits into from
Jul 20, 2023

Conversation

hoc081098
Copy link
Collaborator

@hoc081098 hoc081098 commented Jun 24, 2023

In flutter, there is Notification class https://api.flutter.dev/flutter/widgets/Notification-class.html, sometimes, it causes imports conflict

@hoc081098 hoc081098 changed the title refactor(utils): rename Notification to RxNotification refactor(utils): rename Notification to StreamNotification Jun 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #731 (9856b79) into master (1c3f9ca) will decrease coverage by 0.43%.
The diff coverage is 83.90%.

@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
- Coverage   93.51%   93.08%   -0.43%     
==========================================
  Files          77       78       +1     
  Lines        2407     2431      +24     
==========================================
+ Hits         2251     2263      +12     
- Misses        156      168      +12     

@hoc081098 hoc081098 changed the title refactor(utils): rename Notification to StreamNotification refactor(utils): rename Notification to StreamNotification, Kind to NotificationKind Jul 20, 2023
@hoc081098 hoc081098 merged commit b3dc961 into ReactiveX:master Jul 20, 2023
6 checks passed
@hoc081098 hoc081098 deleted the hoc081098/rename_notification branch July 20, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants