Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove deprecated packages flag #674

Merged

Conversation

beeth0ven
Copy link
Contributor

Hi there.

Form coverage v1.3.0 - 2022-5-11 changelog:

Add a --package flag, which takes the package's root directory, instead of the .package file. Deprecate the --packages flag.

Our ci raised an issue the same as dart-lang/tools#489, the quick fix would be remove deprecated packages flag as metioned here.

Thanks.

@codecov-commenter
Copy link

Codecov Report

Merging #674 (27ef9c5) into master (fe83b90) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files          74       74           
  Lines        2284     2284           
=======================================
  Hits         2136     2136           
  Misses        148      148           

Copy link
Collaborator

@hoc081098 hoc081098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @beeth0ven

@hoc081098 hoc081098 merged commit abec6e7 into ReactiveX:master May 15, 2022
@beeth0ven beeth0ven deleted the ci/remove-deprecated-packages-flag branch May 16, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants