Improved CompositeSubscription #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #633 +/- ##
=======================================
Coverage 92.94% 92.94%
=======================================
Files 74 74
Lines 2225 2225
=======================================
Hits 2068 2068
Misses 157 157 |
hoc081098
reviewed
Sep 24, 2021
| /// Remove the subscription from this composite and cancel it if it has been removed. | ||
| Future<void>? remove( | ||
| StreamSubscription<dynamic> subscription, { | ||
| bool canCancel = true, |
There was a problem hiding this comment.
I think we should use bool shouldCancel = true :))
…w return a completion future - Fixed an issue where a stream not present in CompositeSubscription was canceled - Added the ability not to cancel the stream when it is removed from CompositeSubscription
BreX900
force-pushed
the
group_subscription
branch
from
3d0e7da
to
d2f33d4
Compare
|
@hoc081098 Wouldn't it be more correct to use |
I think |
hoc081098
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dispose,clear, andremovemethods now return a completion future