Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port parameter #383

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Add port parameter #383

merged 4 commits into from
Jul 2, 2024

Conversation

KamilKurde
Copy link
Contributor

The problem

Currently, this action uses ADB commands without specifying device/emulator to use.
This is fine for GitHub-hosted machines, as they are isolated from each other, but becomes a problem when using this action on self-hosted machine, as ADB commands will fail if there are multiple devices present, and it wasn't specified which one to use.

The fix

Adding emulator-port input, that allows a job to specify port to start emulator on.
This way, one machine could have up to 16 emulators running at the same time (due to constraints in port range) without interfering with each other.

@pankajkakkar
Copy link

May I please add a vote for getting this PR merged? It doesn't sound like there are any blockers from the conversation above. I'm facing this issue as well, and every time I want to run a workflow on my repo I have to shut down any running emulators on my Mac.

There's also an open issue #293 on this topic.

@ychescale9 ychescale9 merged commit 4b0628e into ReactiveCircus:main Jul 2, 2024
ychescale9 added a commit that referenced this pull request Jul 9, 2024
ychescale9 added a commit that referenced this pull request Jul 9, 2024
* main:
  Prepare for release 2.32.0.
  Add missing compiled js files from #383.
  Support customizing emulator port (#383)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants