Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SET_TYPEOF() call #6313

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Remove SET_TYPEOF() call #6313

merged 2 commits into from
Jul 26, 2024

Conversation

MichaelChirico
Copy link
Member

Part of #6180 thanks to the helpful suggestion in R-exts:

An alternative way to construct the expression that will work in
any @R{} version is

@example
SEXP expr = LCONS(R_NilValue, allocList(2));
@end example

@MichaelChirico MichaelChirico mentioned this pull request Jul 26, 2024
11 tasks
Copy link

github-actions bot commented Jul 26, 2024

Comparison Plot

Generated via commit 57cb810

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 50 seconds

Time taken to run atime::atime_pkg on the tests: 3 minutes and 35 seconds

@ben-schwen
Copy link
Member

LGTM

@ben-schwen ben-schwen merged commit f972c25 into master Jul 26, 2024
5 checks passed
@ben-schwen ben-schwen deleted the set-typeof branch July 26, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants