Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First look for .datatable.aware in environment #4909

Merged
merged 6 commits into from
Jul 26, 2021

Conversation

hadley
Copy link
Contributor

@hadley hadley commented Feb 17, 2021

This is a PR requested by @MichaelChirico to kick off discussion of the issue described in tidyverse/dtplyr#184 — i.e., it would be nice if dtplyr could declare the code that it generates and evaluates is data.table aware, independently of what package that is running that code.

If this idea seems interesting/promising I'm happy to finish off with a NEWS bullet, tests (although I'm not yet sure how to test this specific), etc. But I wanted to make sure this contribution was appropriate before doing more work.

R/cedta.R Outdated Show resolved Hide resolved
@mattdowle mattdowle added this to the 1.14.1 milestone Jul 26, 2021
@mattdowle
Copy link
Member

Thanks, @hadley. Great solution.
I'm not sure how to test this either from data.table's side. I'll add the news item and merge so you or your team can test either dev now or after release. I don't see much risk in adding this given it's just looking for .datatable.aware in the calling environment as well now. If it doesn't work we can always revisit.
I've invited you to be project member (it should be a button you need to click in your GitHub profile or projects page) and will add you to contributors list. This is our standard practice for any code change PRs. Thanks again.

@mattdowle mattdowle merged commit f9ebb1b into Rdatatable:master Jul 26, 2021
@hadley
Copy link
Contributor Author

hadley commented Jul 30, 2021

Got it, thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants