Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass clang-ubsan #4624

Merged
merged 1 commit into from
Jul 21, 2020
Merged

pass clang-ubsan #4624

merged 1 commit into from
Jul 21, 2020

Conversation

mattdowle
Copy link
Member

@mattdowle mattdowle commented Jul 21, 2020

Fixes these observed locally, all in fread.c.
The nan one is a follow up to #4464.
Using clang-10 as per CRAN_Release.cmd. Does not show up under gcc-9, at least with the default options I used.

test.data.table() running: /home/mdowle/build/R-devel-strict-clang/library/data.table/tests/tests.Rraw 
Running test id 880      fread.c:992:15: runtime error: nan is outside the range of representable values of type 'int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior fread.c:992:15 in 
Running test id 899.1      fread.c:2273:43: runtime error: applying zero offset to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior fread.c:2273:43 in 
Running test id 899.3      fread.c:2286:43: runtime error: applying zero offset to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior fread.c:2286:43 in 
fread.c:2387:39: runtime error: applying zero offset to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior fread.c:2387:39 in 

This will also fix the only 'additional issue' currently being reported on CRAN with 1.12.8 too :

test.data.table() running: /data/gannet/ripley/R/packages/tests-clang-SAN/data.table.Rcheck/data.table/tests/tests.Rraw.bz2 
  fread.c:2114:43: runtime error: applying zero offset to null pointer
... etc

@mattdowle mattdowle added this to the 1.12.9 milestone Jul 21, 2020
@mattdowle mattdowle mentioned this pull request Jul 21, 2020
29 tasks
@mattdowle mattdowle merged commit cbd99d4 into master Jul 21, 2020
@mattdowle mattdowle deleted the clang-ubsan branch July 21, 2020 07:10
hongyuanjia pushed a commit to hongyuanjia/data.table that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant