Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy run #160

Merged
merged 5 commits into from
Jun 28, 2024
Merged

clippy run #160

merged 5 commits into from
Jun 28, 2024

Conversation

asibahi
Copy link
Contributor

@asibahi asibahi commented Jun 27, 2024 •
edited

Went over the project with clippy.

One thing I don't understand is the errors in the benches folder. What's the deal with the undeclared bencher module? How do.I deal with it?

RazrFalcon
RazrFalcon reviewed Jun 28, 2024
View reviewed changes
src/tables/glyf.rs Outdated Show resolved Hide resolved
@RazrFalcon
Copy link
Owner

Thanks, but for the future I do not accept clipping and formatting fixes.

@asibahi
Copy link
Contributor Author

asibahi commented Jun 28, 2024 •
edited

Thanks, but for the future I do not accept clipping and formatting fixes.

Noted, and thank you.

RazrFalcon
RazrFalcon reviewed Jun 28, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@RazrFalcon
Copy link
Owner

Looks like data.extend([2; 100]); is a fairly new feature. Let's revert it as well.

@RazrFalcon RazrFalcon merged commit b0d2c87 into RazrFalcon:master Jun 28, 2024
2 checks passed
@RazrFalcon
Copy link
Owner

Thanks!

@asibahi asibahi deleted the clippy_run branch June 28, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazrFalcon RazrFalcon RazrFalcon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asibahi @RazrFalcon