Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement global objects as functions that return a single instance #175

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

loathingKernel
Copy link
Contributor

As the title suggests, remove the global objects in shared and instead used functions to instantiate or return them.

They are still reside in rare.shared but that doesn't need to be the case any more. They can be moved into the same files
where each class is implemented for better concept encapsulation. I left them there to make the change-set as minimal as possible
because we have various branches running around right now.

I also sneaked in a few worker signal classes renames, as it was getting confusing to keep track what signals each field was referring too.

@Dummerle
Copy link
Collaborator

Does it work now for HiDPI devices?

@loathingKernel
Copy link
Contributor Author

loathingKernel commented Feb 25, 2022

No, that HiDPI commit is just for the qtawesome icons to scale properly. MultisampledNight asked if I could add it to the PR on discord.

@Dummerle Dummerle merged commit 6d356da into RareDevs:main Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants