Implement global objects as functions that return a single instance #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests, remove the global objects in shared and instead used functions to instantiate or return them.
They are still reside in
rare.shared
but that doesn't need to be the case any more. They can be moved into the same fileswhere each class is implemented for better concept encapsulation. I left them there to make the change-set as minimal as possible
because we have various branches running around right now.
I also sneaked in a few worker signal classes renames, as it was getting confusing to keep track what signals each field was referring too.