Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Say command #55

Closed
wants to merge 9 commits into from
Closed

Say command #55

wants to merge 9 commits into from

Conversation

seanohue
Copy link
Contributor

@seanohue seanohue commented Nov 9, 2015

This command allows players to say a message which will only be seen by players who are in the same room.

@shawncplus
Copy link
Member

lots of neat pull requests, I'll try to merge them tonight. I'm interested in how you found the project and what you're using it for. I saw this tweet https://twitter.com/tomdale/status/660893508715339776 and assumed that was the source of the new contributors, maybe that's not the case though

@seanohue
Copy link
Contributor Author

@shawncplus I found the project about 5-6 months ago when I started learning JavaScript because I enjoy MUDs and wanted to see if there were any written purely in JS. I literally just searched for MUDs written in JS on Github.

RanvierMUD is the only one I found, so I started poking at it and trying to contribute. Mostly I've just been using it for fun and for learning but maybe someday I'll host an actual fleshed-out MUD server using it.

I have all of the new PRs merged in on my branch and since some of them depend on each other in funny ways I also coded some bits to make them all gel together (for example, merging in descriptions and the character command means that typing char will cause an error). I can submit another PR to fix that once they're merged, or submit a giant kitchen sink PR, or add error handling.

Thanks!

@seanohue
Copy link
Contributor Author

I also posted a reddit thread about it recently, since I thought it was a cool project and hoped it'd attract some more interest: https://www.reddit.com/r/MUD/comments/3ryy4l/ranviermud_a_lightweight_mud_engine_being/

@marado
Copy link
Contributor

marado commented Nov 11, 2015

@shawncplus I bumped into this project (and my interest in it comes) from a discussion in another project: amnuts/Amnuts#4 . Glad to see this project active!

@seanohue
Copy link
Contributor Author

@shawncplus this one plays well with all of the previous PRs.

@seanohue
Copy link
Contributor Author

seanohue commented Feb 9, 2016

Closed because it's just duplicating the say command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants