Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute recorded commands in order #329

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Execute recorded commands in order #329

merged 3 commits into from
Jul 3, 2023

Conversation

Ralith
Copy link
Owner

@Ralith Ralith commented Jul 2, 2023

No description provided.

Copy link

@LPGhatguy LPGhatguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think the code gets overall a little bit more readable with this change as a nice bonus.

src/command_buffer.rs Show resolved Hide resolved
Copy link

@LPGhatguy LPGhatguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Fixes surprising behavior when inserting a component that was
previously removed in the same command buffer.
@Ralith Ralith enabled auto-merge (rebase) July 3, 2023 01:05
@Ralith Ralith merged commit bc78f89 into master Jul 3, 2023
4 checks passed
@Ralith Ralith deleted the ordered-command-buffer branch July 3, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants