Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clutter caller namespace with derive(Query) internals #326

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

Ralith
Copy link
Owner

@Ralith Ralith commented Jun 24, 2023

Rather than giving the Fetch/State types names unlikely to collide, we can introduce fully hygenic names by moving the type definitions and the trait impls that depend on them into an anonymous scope.

This was intended as groundwork for making derive(Query) work for queries where Query::Item and Self structurally differ (like Without) but that makes it impossible to derive attributes for the query item, which seems suboptimal. Still, useful cleanup.

Rather than giving the Fetch/State types names unlikely to collide, we
can introduce fully hygenic names by moving the type definitions and
the trait impls that depend on them into an anonymous scope.
@Ralith Ralith merged commit d41ca1d into master Jun 24, 2023
4 checks passed
@Ralith Ralith deleted the derive-query-cleanup branch June 24, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant