Rewrite and test the Bundle derive macro #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Thanks, this is great! No serious issues, though if you want to rewrite the history a bit we could rebase rather than squashing and keep history a little more discrete.
though I guess unit structs are kind of pointless to use?
I could imagine them coming up occasionally with feature-gated or macro-generated component fields. Definitely worth supporting, given that it's not hugely difficult to do so.
macros/src/lib.rs
Outdated
| .as_ptr(); | ||
| )* | ||
| Ok(Self { #( #fields: #fields.read(), )* }) | ||
| } |
There was a problem hiding this comment.
Rather than having two code paths here, could we resolve the issue with type annotations?
|
Alright, the history should be cleaner now |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the derive macro, makes it hygienic and fixes it not working for tuple structs and unit structs(though I guess unit structs are kind of pointless to use?).
I wanted to tackle adding generics but figured adding proper testing first would make more sense.