-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evm-statemanager #67
Open
SoujanyaPonnapalli
wants to merge
29
commits into
master
Choose a base branch
from
evm-statemanager
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
evm-statemanager #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to evm-statemanager
Hello! I was looking for a way to implement checkpointing on top of your library and found this PR. I was wondering about the status, and wanted to offer my help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following features:
MerklePatriciaTree
class supportscopy
andcreateReadStream
now.copy
: Sets a flag which says that the updates henceforth to the tree should not happen in place. If the flag is set, the nodes in the search path for the key are copied and the copied path is updated to have the key. So if a copied tree is updated; the original tree remains unchanged.createReadStream
: returns all the key value pairs stores in the trie as a readable stream of {key: key, value: value} pairsCheckpointTrie
extendsMerklePatriciaTree
to supportcommit
,revert
andcheckpoint
Checkpoint
: Creates a checkpoint that can later be reverted back to or committed to. Updates to the tree after a checkpoint will be temporary until a commit is called.Commit
: Finalizes the temporary updates, if there are no nested checkpoints. If there are, drops the latest checkpoint and sets its parent as the current checkpointRevert
: Revert to the most recent checkpoint. If there are nested checkpoints, sets the parent of the recent checkpoint as the current checkpoint.SecureTrie
extendsCheckpointTrie
This class stores/retrieves values in/from the trie against the hashed key.
Tests for
CheckpointTrie
andSecureTrie
are added based on the tests in the ethereumjs/merkle-patricia-tree repo.